Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1629103
| From | Pan Bian <bianpan2016@163.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 1/1] power: Fix unchecked return value of devm_kzalloc |
| Date | 2017-04-24 02:40 +0200 |
| Message-ID | <tzAcN-7F3-11@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
Function devm_kzalloc() will return a NULL pointer. However, in function isp1704_charger_probe(), the return value of devm_kzalloc() is directly used without validation. This may result in a bad memory access bug. Signed-off-by: Pan Bian <bianpan2016@163.com> --- drivers/power/supply/isp1704_charger.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/power/supply/isp1704_charger.c b/drivers/power/supply/isp1704_charger.c index 4cd6899..2f02463 100644 --- a/drivers/power/supply/isp1704_charger.c +++ b/drivers/power/supply/isp1704_charger.c @@ -418,6 +418,8 @@ static int isp1704_charger_probe(struct platform_device *pdev) pdata = devm_kzalloc(&pdev->dev, sizeof(struct isp1704_charger_data), GFP_KERNEL); + if (pdata) + goto fail0; pdata->enable_gpio = gpio; dev_info(&pdev->dev, "init gpio %d\n", pdata->enable_gpio); -- 1.9.1
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH 1/1] power: Fix unchecked return value of devm_kzalloc Pan Bian <bianpan2016@163.com> - 2017-04-24 02:40 +0200 Re: [PATCH 1/1] power: Fix unchecked return value of devm_kzalloc Pali Rohár <pali.rohar@gmail.com> - 2017-04-24 09:20 +0200
csiph-web