RE:drivers:net:ethernet:adi:bfin_mac: Use FIELD_SIZEOF defined kernel macro

From	Karim Eshapa <karim.eshapa@gmail.com>
Newsgroups	linux.kernel
Subject	RE:drivers:net:ethernet:adi:bfin_mac: Use FIELD_SIZEOF defined kernel macro
Date	2017-04-24 02:30 +0200
Message-ID	<tzA37-7Bc-1@gated-at.bofh.it> (permalink)
References	<tzu7o-3tw-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, 23 Apr 2017 22:56:38 +0200, Geert Uytterhoeven:
>IMHO this makes the code less safe and less future-proof.
>What if the type of info is ever changed?
>There's no safety check to validate that the FIELD_SIZEOF() operates on the
>same data as the strlcpy() destination.

Really make sense :)

>As the kbuild test robot already told you, this doesn't compile.
>Please try to (at least) compile the code before sending patches.
>Thanks!

So sorry for that I built quickly using the wrong compiler and the wrong 
target machine with my old .config that's horrible :)

Thanks a lot,
Karim

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] drivers:net:ethernet:adi:bfin_mac: Use FIELD_SIZEOF defined kernel macro Karim Eshapa <karim.eshapa@gmail.com> - 2017-04-23 20:10 +0200
  Re: [PATCH 1/1] drivers:net:ethernet:adi:bfin_mac: Use FIELD_SIZEOF  defined kernel macro kbuild test robot <lkp@intel.com> - 2017-04-23 22:20 +0200
  Re: [PATCH 1/1] drivers:net:ethernet:adi:bfin_mac: Use FIELD_SIZEOF  defined kernel macro Geert Uytterhoeven <geert@linux-m68k.org> - 2017-04-23 23:00 +0200
  RE:drivers:net:ethernet:adi:bfin_mac: Use FIELD_SIZEOF defined kernel macro Karim Eshapa <karim.eshapa@gmail.com> - 2017-04-24 02:30 +0200

csiph-web