Re: [PATCH 05/28] drm/bridge: fix include notation and remove -Iinclude/drm flag

From	Andrzej Hajda <a.hajda@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 05/28] drm/bridge: fix include notation and remove -Iinclude/drm flag
Date	2017-04-21 08:00 +0200
Message-ID	<tyzLP-22i-5@gated-at.bofh.it> (permalink)
References	<tyh2x-7kt-3@gated-at.bofh.it> <tyzLP-22i-7@gated-at.bofh.it> <tyhce-7D4-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Masahiro,

On 20.04.2017 11:56, Masahiro Yamada wrote:
> Include <drm/*.h> instead of relative path from include/drm, then
> remove the -Iinclude/drm compiler flag.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
>  drivers/gpu/drm/bridge/Makefile        |  2 --
>  drivers/gpu/drm/bridge/nxp-ptn3460.c   | 10 +++++-----
>  drivers/gpu/drm/bridge/parade-ps8622.c |  8 ++++----
>  3 files changed, 9 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/Makefile b/drivers/gpu/drm/bridge/Makefile
> index 3fe2226..defcf1e 100644
> --- a/drivers/gpu/drm/bridge/Makefile
> +++ b/drivers/gpu/drm/bridge/Makefile
> @@ -1,5 +1,3 @@
> -ccflags-y := -Iinclude/drm
> -
>  obj-$(CONFIG_DRM_ANALOGIX_ANX78XX) += analogix-anx78xx.o
>  obj-$(CONFIG_DRM_DUMB_VGA_DAC) += dumb-vga-dac.o
>  obj-$(CONFIG_DRM_LVDS_ENCODER) += lvds-encoder.o
> diff --git a/drivers/gpu/drm/bridge/nxp-ptn3460.c b/drivers/gpu/drm/bridge/nxp-ptn3460.c
> index 3517043..3fc285a 100644
> --- a/drivers/gpu/drm/bridge/nxp-ptn3460.c
> +++ b/drivers/gpu/drm/bridge/nxp-ptn3460.c
> @@ -24,11 +24,11 @@
>  #include <drm/drm_of.h>
>  #include <drm/drm_panel.h>
>  
> -#include "drm_crtc.h"
> -#include "drm_crtc_helper.h"
> -#include "drm_atomic_helper.h"
> -#include "drm_edid.h"
> -#include "drmP.h"
> +#include <drm/drm_crtc.h>
> +#include <drm/drm_crtc_helper.h>
> +#include <drm/drm_atomic_helper.h>
> +#include <drm/drm_edid.h>
> +#include <drm/drmP.h>

Could you merge these includes with the ones above and sort them
alphabetically.

>  
>  #define PTN3460_EDID_ADDR			0x0
>  #define PTN3460_EDID_EMULATION_ADDR		0x84
> diff --git a/drivers/gpu/drm/bridge/parade-ps8622.c b/drivers/gpu/drm/bridge/parade-ps8622.c
> index 1dcec3b..ada2186 100644
> --- a/drivers/gpu/drm/bridge/parade-ps8622.c
> +++ b/drivers/gpu/drm/bridge/parade-ps8622.c
> @@ -28,10 +28,10 @@
>  #include <drm/drm_of.h>
>  #include <drm/drm_panel.h>
>  
> -#include "drmP.h"
> -#include "drm_crtc.h"
> -#include "drm_crtc_helper.h"
> -#include "drm_atomic_helper.h"
> +#include <drm/drmP.h>
> +#include <drm/drm_crtc.h>
> +#include <drm/drm_crtc_helper.h>
> +#include <drm/drm_atomic_helper.h>

Ditto.

After this change you can add my:
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>

 --
Regards
Andrzej


>  
>  /* Brightness scale on the Parade chip */
>  #define PS8622_MAX_BRIGHTNESS 0xff

Thread

[PATCH 00/28] gpu/drm: remove -Iinclude/drm compiler flags from Makefile Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-04-20 12:00 +0200
  [PATCH 18/28] drm/i810: remove unneeded -Iinclude/drm compiler flag Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-04-20 12:10 +0200
  [PATCH 23/28] drm/savage: remove unneeded -Iinclude/drm compiler flag Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-04-20 12:10 +0200
  [PATCH 15/28] drm/virtio: fix include notation and remove -Iinclude/drm flag Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-04-20 12:10 +0200
  [PATCH 10/28] drm/nouveau: fix include notation and remove -Iinclude/drm flag Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-04-20 12:10 +0200
  [PATCH 05/28] drm/bridge: fix include notation and remove -Iinclude/drm flag Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-04-20 12:10 +0200
    Re: [PATCH 05/28] drm/bridge: fix include notation and remove  -Iinclude/drm flag Andrzej Hajda <a.hajda@samsung.com> - 2017-04-21 08:00 +0200
      Re: [PATCH 05/28] drm/bridge: fix include notation and remove  -Iinclude/drm flag Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-04-21 11:00 +0200
  [PATCH 26/28] drm/udl: remove unneeded -Iinclude/drm compiler flag Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-04-20 12:10 +0200
  [PATCH 17/28] drm/gma500: remove unneeded -Iinclude/drm compiler flag Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-04-20 12:10 +0200
  [PATCH 11/28] drm/qxl: fix include notation and remove -Iinclude/drm flag Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-04-20 12:10 +0200
  [PATCH 27/28] drm/vgem: remove unneeded -Iinclude/drm compiler flag Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-04-20 12:10 +0200
  [PATCH 22/28] drm/r128: remove unneeded -Iinclude/drm compiler flag Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-04-20 12:10 +0200
  [PATCH 28/28] drm/via: remove unneeded -Iinclude/drm compiler flag Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-04-20 12:10 +0200
  [PATCH 07/28] drm/hisilicon: fix include notation and remove -Iinclude/drm flag Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-04-20 12:10 +0200
  [PATCH 08/28] drm/mgag200: fix include notation and remove -Iinclude/drm flag Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-04-20 12:10 +0200
  [PATCH 19/28] drm/i2c: remove unneeded -Iinclude/drm compiler flag Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-04-20 12:10 +0200
  [PATCH 25/28] drm/tdfx: remove unneeded -Iinclude/drm compiler flag Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-04-20 12:10 +0200
  [PATCH 24/28] drm/sis: remove unneeded -Iinclude/drm compiler flag Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-04-20 12:10 +0200
  [PATCH 20/28] drm/mga: remove unneeded -Iinclude/drm compiler flag Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-04-20 12:10 +0200
  [PATCH 03/28] drm/ast: fix include notation and remove -Iinclude/drm flag Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-04-20 12:10 +0200
  [PATCH 14/28] drm/vc4: fix include notation and remove -Iinclude/drm flag Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-04-20 12:10 +0200

csiph-web