Re: [PATCH v2] PCI: disable SERR for kdump kernel

From	Sinan Kaya <okaya@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] PCI: disable SERR for kdump kernel
Date	2017-04-21 02:10 +0200
Message-ID	<tyuj7-7eG-3@gated-at.bofh.it> (permalink)
References	<txLP4-4F9-5@gated-at.bofh.it> <tynUl-3h3-11@gated-at.bofh.it> <tytQ5-6Qy-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 4/20/2017 7:37 PM, Yinghai Lu wrote:
> On Thu, Apr 20, 2017 at 10:14 AM, Sinan Kaya <okaya@codeaurora.org> wrote:
>> On 4/18/2017 8:31 PM, Yinghai Lu wrote:
>>> * pci_setup_device - fill in class and map information of a device
>>>   * @dev: the device structure to fill
>>> @@ -1572,6 +1592,9 @@ int pci_setup_device(struct pci_dev *dev
>>>       /* device class may be changed after fixup */
>>>       class = dev->class >> 8;
>>>
>>> +     if (is_kdump_kernel())
>>> +             pci_disable_serr(dev);
>>> +
>>
>> This sounds like something that needs to be done while shutting down
>> the first kernel as part of the kdump procedure rather than boot of
>> the kdump kernel in pci setup.
> 
> For kdump path, first kernel shutdown path is not called.
> 
> We have to do sth in second kernel instead.
> 

I didn't know that. Bjorn's compatibility point is also a concern. 
Ideally you want something in both places.

> Thanks
> 
> Yinghai
> 


-- 
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] PCI: disable SERR for kdump kernel Yinghai Lu <yinghai@kernel.org> - 2017-04-19 02:40 +0200
  Re: [PATCH v2] PCI: disable SERR for kdump kernel Sinan Kaya <okaya@codeaurora.org> - 2017-04-20 19:20 +0200
    Re: [PATCH v2] PCI: disable SERR for kdump kernel Bjorn Helgaas <bhelgaas@google.com> - 2017-04-20 20:40 +0200
      Re: [PATCH v2] PCI: disable SERR for kdump kernel Sinan Kaya <okaya@codeaurora.org> - 2017-04-20 21:00 +0200
    Re: [PATCH v2] PCI: disable SERR for kdump kernel Yinghai Lu <yinghai@kernel.org> - 2017-04-21 01:40 +0200
      Re: [PATCH v2] PCI: disable SERR for kdump kernel Sinan Kaya <okaya@codeaurora.org> - 2017-04-21 02:10 +0200

csiph-web