Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1627803

[PATCH v3 2/2] nvme: Quirk APST off on "THNSF5256GPUK TOSHIBA"

From Andy Lutomirski <luto@kernel.org>
Newsgroups linux.kernel
Subject [PATCH v3 2/2] nvme: Quirk APST off on "THNSF5256GPUK TOSHIBA"
Date 2017-04-20 22:40 +0200
Message-ID <tyr1U-565-23@gated-at.bofh.it> (permalink)
References <tyr1T-565-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


There's a report that it malfunctions with APST on.

See https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1678184

Cc: Kai-Heng Feng <kai.heng.feng@canonical.com>
Signed-off-by: Andy Lutomirski <luto@kernel.org>
---
 drivers/nvme/host/core.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 00b2818dac31..eeb409c287b8 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -1395,6 +1395,15 @@ struct nvme_core_quirk_entry {
 };
 
 static const struct nvme_core_quirk_entry core_quirks[] = {
+	{
+		/*
+		 * This Toshiba device seems to die using any APST states.  See:
+		 * https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1678184/comments/11
+		 */
+		.vid = 0x1179,
+		.mn = "THNSF5256GPUK TOSHIBA",
+		.quirks = NVME_QUIRK_NO_APST,
+	}
 };
 
 /* match is null-terminated but idstr is space-padded. */
-- 
2.9.3

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v3 0/2] nvme APST quirk updates, take two Andy Lutomirski <luto@kernel.org> - 2017-04-20 22:40 +0200
  [PATCH v3 2/2] nvme: Quirk APST off on "THNSF5256GPUK TOSHIBA" Andy Lutomirski <luto@kernel.org> - 2017-04-20 22:40 +0200
  [PATCH v3 1/2] nvme: Adjust the Samsung APST quirk Andy Lutomirski <luto@kernel.org> - 2017-04-20 22:40 +0200
  Re: [PATCH v3 0/2] nvme APST quirk updates, take two Jens Axboe <axboe@kernel.dk> - 2017-04-21 01:40 +0200

csiph-web