Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1627717

Re: [PATCH 3/4] tty/serdev: add serdev registration interface

Show all headers | View raw

On Tue, Apr 11, 2017 at 12:07 PM, Johan Hovold <johan@kernel.org> wrote:
> Add a new interface for registering a serdev controller and clients, and
> a helper function to deregister serdev devices (or a tty device) that
> were previously registered using the new interface.
>
> Once every driver currently using the tty_port_register_device() helpers
> have been vetted and converted to use the new serdev registration
> interface (at least for deregistration), we can move serdev registration
> to the current helpers and get rid of the serdev-specific functions.

I don't really think this is necessary. While in theory any tty port
can work with serdev, the reality is it only ever going to be used
with a few. There's about 31 possible drivers. Of those, there's a
fair number that an attached device is not going to make sense (e.g.
ISDN CAPI, rfcomm?, goldfish, etc.). Second, right now serdev only
works with DT binding. There are only 3 drivers supporting DT:
serial_core, goldfish, and ehv_bytechan. Likely drivers I'm aware of
to use serdev in addition to serial_core are USB serial and greybus.
But for those, we currently only could support them if the whole bus
topology is described in DT. Otherwise, we first have to figure out
how to apply DT overlays to arbitrary devices not described in DT.

OTOH, we are at least explicit with what tty ports support serdev.

Rob

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] serdev: fix broken lifetime assumptions Johan Hovold <johan@kernel.org> - 2017-04-11 19:10 +0200
  [PATCH 2/4] serdev: fix tty-port client deregistration Johan Hovold <johan@kernel.org> - 2017-04-11 19:10 +0200
  [PATCH 1/4] Revert "tty_port: register tty ports with serdev bus" Johan Hovold <johan@kernel.org> - 2017-04-11 19:10 +0200
    Re: [PATCH 1/4] Revert "tty_port: register tty ports with serdev bus" Johan Hovold <johan@kernel.org> - 2017-04-12 16:40 +0200
  [PATCH 3/4] tty/serdev: add serdev registration interface Johan Hovold <johan@kernel.org> - 2017-04-11 19:10 +0200
    Re: [PATCH 3/4] tty/serdev: add serdev registration interface Rob Herring <robh@kernel.org> - 2017-04-20 20:00 +0200
      Re: [PATCH 3/4] tty/serdev: add serdev registration interface Johan Hovold <johan@kernel.org> - 2017-04-21 20:30 +0200

csiph-web