Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1627595

Re: [PATCH] rcuperf: refix rcuperf sched_ops definition

Path csiph.com!1.us.feeder.erje.net!2.eu.feeder.erje.net!feeder.erje.net!1.eu.feeder.erje.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Newsgroups linux.kernel
Subject Re: [PATCH] rcuperf: refix rcuperf sched_ops definition
Date Thu, 20 Apr 2017 17:40:01 +0200
Message-ID <tymlz-2fX-7@gated-at.bofh.it> (permalink)
References <tyftL-6wC-1@gated-at.bofh.it>
Reply-To paulmck@linux.vnet.ibm.com
MIME-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Disposition inline
User-Agent Mutt/1.5.21 (2010-09-15)
X-Tm-As-Gconf 00
X-Cbid 17042015-0052-0000-0000-000001DF520A
X-Ibm-Spammodules-Versions BY=3.00006945; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000208; SDB=6.00850135; UDB=6.00419855; IPR=6.00628764; BA=6.00005305; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00015110; XFM=3.00000013; UTC=2017-04-20 15:35:32
X-Ibm-Av-Detection SAVI=unused REMOTE=unused XFE=unused
X-Cbparentid 17042015-0053-0000-0000-00005019CA41
X-Proofpoint-Virus-Version vendor=fsecure engine=2.50.10432:,, definitions=2017-04-20_14:,, signatures=0
X-Proofpoint-Spam-Details rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1704200125
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 36
Organization linux.* mail to news gateway
X-Original-Cc Josh Triplett <josh@joshtriplett.org>, Steven Rostedt <rostedt@goodmis.org>, Mathieu Desnoyers <mathieu.desnoyers@efficios.com>, Lai Jiangshan <jiangshanlai@gmail.com>, SeongJae Park <sj38.park@gmail.com>, Ingo Molnar <mingo@kernel.org>, linux-kernel@vger.kernel.org
X-Original-Date Thu, 20 Apr 2017 08:35:29 -0700
X-Original-Message-ID <20170420153529.GP3956@linux.vnet.ibm.com>
X-Original-References <20170420081247.657073-1-arnd@arndb.de>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1627595

Show key headers only | View raw


On Thu, Apr 20, 2017 at 10:12:31AM +0200, Arnd Bergmann wrote:
> It looks like my fixup was incorrectly folded into the original patch,
> and still leaves a duplicated initializer but drops the .sync
> callback pointer.
> 
> This should rectify it, please fold it as well.
> 
> Fixes: df29028c2a9c ("rcuperf: Add ability to performance-test call_rcu() and friends")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

I really am not doing well on this commit, am I?  :-/

Thank you very much for your attention to detail and for the fixes!!!

							Thanx, Paul

> ---
>  kernel/rcu/rcuperf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/rcu/rcuperf.c b/kernel/rcu/rcuperf.c
> index 1e2a1424d1f5..5158ddba6716 100644
> --- a/kernel/rcu/rcuperf.c
> +++ b/kernel/rcu/rcuperf.c
> @@ -308,7 +308,7 @@ static struct rcu_perf_ops sched_ops = {
>  	.exp_completed	= rcu_exp_batches_completed_sched,
>  	.async		= call_rcu_sched,
>  	.gp_barrier	= rcu_barrier_sched,
> -	.async		= srcu_call_rcu,
> +	.sync		= synchronize_sched,
>  	.exp_sync	= synchronize_sched_expedited,
>  	.name		= "sched"
>  };
> -- 
> 2.9.0
> 

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH] rcuperf: refix rcuperf sched_ops definition Arnd Bergmann <arnd@arndb.de> - 2017-04-20 10:20 +0200
  Re: [PATCH] rcuperf: refix rcuperf sched_ops definition "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-04-20 17:40 +0200

csiph-web