Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1627534

Re: [PATCH v4 1/3] kexec: Move vmcoreinfo out of the kernel's .bss section

From Juergen Gross <jgross@suse.com>
Newsgroups linux.kernel
Subject Re: [PATCH v4 1/3] kexec: Move vmcoreinfo out of the kernel's .bss section
Date 2017-04-20 16:30 +0200
Message-ID <tylfQ-1Ck-13@gated-at.bofh.it> (permalink)
References <tyiKZ-8qv-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 20/04/17 13:39, Xunlei Pang wrote:
> As Eric said,
> "what we need to do is move the variable vmcoreinfo_note out
> of the kernel's .bss section.  And modify the code to regenerate
> and keep this information in something like the control page.
> 
> Definitely something like this needs a page all to itself, and ideally
> far away from any other kernel data structures.  I clearly was not
> watching closely the data someone decided to keep this silly thing
> in the kernel's .bss section."
> 
> This patch allocates extra pages for these vmcoreinfo_XXX variables,
> one advantage is that it enhances some safety of vmcoreinfo, because
> vmcoreinfo now is kept far away from other kernel data structures.
> 
> Suggested-by: Eric Biederman <ebiederm@xmission.com>
> Cc: Michael Holzheu <holzheu@linux.vnet.ibm.com>
> Cc: Juergen Gross <jgross@suse.com>
> Signed-off-by: Xunlei Pang <xlpang@redhat.com>

Xen parts: Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v4 1/3] kexec: Move vmcoreinfo out of the kernel's .bss section Xunlei Pang <xlpang@redhat.com> - 2017-04-20 13:50 +0200
  [PATCH v4 2/3] powerpc/fadump: Use the correct VMCOREINFO_NOTE_SIZE for phdr Xunlei Pang <xlpang@redhat.com> - 2017-04-20 13:50 +0200
    Re: [PATCH v4 2/3] powerpc/fadump: Use the correct  VMCOREINFO_NOTE_SIZE for phdr Xunlei Pang <xpang@redhat.com> - 2017-04-21 03:00 +0200
  [PATCH v4 3/3] kdump: Protect vmcoreinfo data under the crash memory Xunlei Pang <xlpang@redhat.com> - 2017-04-20 13:50 +0200
  Re: [PATCH v4 1/3] kexec: Move vmcoreinfo out of the kernel's .bss  section Juergen Gross <jgross@suse.com> - 2017-04-20 16:30 +0200
  Re: [PATCH v4 1/3] kexec: Move vmcoreinfo out of the kernel's .bss  section Michael Holzheu <holzheu@linux.vnet.ibm.com> - 2017-04-24 17:20 +0200

csiph-web