Re: [PATCH][-next] block, bfq: don't dereference bic before null checking it

From	Jens Axboe <axboe@kernel.dk>
Newsgroups	linux.kernel
Subject	Re: [PATCH][-next] block, bfq: don't dereference bic before null checking it
Date	2017-04-20 16:30 +0200
Message-ID	<tylfP-1Ck-3@gated-at.bofh.it> (permalink)
References	<tykWt-1uY-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Apr 20 2017, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The call to bfq_check_ioprio_change will dereference bic, however,
> the null check for bic is after this call.  Move the the null
> check on bic to before the call to avoid any potential null
> pointer dereference issues.

Thanks, added.

-- 
Jens Axboe

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH][-next] block, bfq: don't dereference bic before null checking it Colin King <colin.king@canonical.com> - 2017-04-20 16:10 +0200
  Re: [PATCH][-next] block, bfq: don't dereference bic before null  checking it Jens Axboe <axboe@kernel.dk> - 2017-04-20 16:30 +0200

csiph-web