Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1627463

Re: [PATCH] Revert "cpuidle: Replace ktime_get() with local_clock()"

From Peter Zijlstra <peterz@infradead.org>
Newsgroups linux.kernel
Subject Re: [PATCH] Revert "cpuidle: Replace ktime_get() with local_clock()"
Date 2017-04-20 15:50 +0200
Message-ID <tykD7-18r-5@gated-at.bofh.it> (permalink)
References <tyjH3-ye-5@gated-at.bofh.it> <tyk0p-Ud-3@gated-at.bofh.it> <tykD7-18r-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Thu, Apr 20, 2017 at 04:43:45PM +0300, Ville Syrjälä wrote:
> On Thu, Apr 20, 2017 at 03:08:13PM +0200, Peter Zijlstra wrote:
> > On Thu, Apr 20, 2017 at 03:44:47PM +0300, ville.syrjala@linux.intel.com wrote:
> > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > 
> > > This reverts commit e93e59ce5b85e6c2b444f09fd1f707274ec066dc.
> > > 
> > > The TSC stops in deeper C states, 
> > 
> > On some old hardware (Core2 era and before) only. You've forgotten to
> > mention what hardware you've observed problems with.
> 
> Yeah, Core2 is what I used when I finally decided to bisect this. I've
> been plagued by the bogus powertop numbers on many machines, most
> likely all of them were of some older vintage.

> Tested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

OK, thanks. I'm currently chasing some other Core2 issue that is
somewhat related. See:

  http://lkml.kernel.org/r/20170413132349.thxkwptdymsfsyxb@hirez.programming.kicks-ass.net

Once I have that sorted I'll post both patches.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] Revert "cpuidle: Replace ktime_get() with local_clock()" ville.syrjala@linux.intel.com - 2017-04-20 14:50 +0200
  Re: [PATCH] Revert "cpuidle: Replace ktime_get() with local_clock()" Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-04-20 15:10 +0200
  Re: [PATCH] Revert "cpuidle: Replace ktime_get() with local_clock()" Peter Zijlstra <peterz@infradead.org> - 2017-04-20 15:10 +0200
    Re: [PATCH] Revert "cpuidle: Replace ktime_get() with local_clock()" Peter Zijlstra <peterz@infradead.org> - 2017-04-20 15:50 +0200
    Re: [PATCH] Revert "cpuidle: Replace ktime_get() with local_clock()" Ville Syrjälä <ville.syrjala@linux.intel.com> - 2017-04-20 15:50 +0200
    Re: [PATCH] Revert "cpuidle: Replace ktime_get() with local_clock()" Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-04-20 16:40 +0200
      Re: [PATCH] Revert "cpuidle: Replace ktime_get() with local_clock()" Peter Zijlstra <peterz@infradead.org> - 2017-04-20 16:50 +0200
      Re: [PATCH] Revert "cpuidle: Replace ktime_get() with local_clock()" Peter Zijlstra <peterz@infradead.org> - 2017-04-20 16:50 +0200

csiph-web