Re: net: heap out-of-bounds in fib6_clean_node/rt6_fill_node/fib6_age/fib6_prune_clone

Path	csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Andrey Konovalov <andreyknvl@google.com>
Newsgroups	linux.kernel
Subject	Re: net: heap out-of-bounds in fib6_clean_node/rt6_fill_node/fib6_age/fib6_prune_clone
Date	Thu, 20 Apr 2017 14:20:01 +0200
Message-ID	<tyje1-o7-15@gated-at.bofh.it> (permalink)
References	<tgZlo-4ue-29@gated-at.bofh.it> <tirSi-2Tr-25@gated-at.bofh.it> <tislk-35L-15@gated-at.bofh.it> <tisOl-3ze-3@gated-at.bofh.it> <tithn-3Jt-21@gated-at.bofh.it> <titAK-46W-23@gated-at.bofh.it> <tiIT8-6v2-23@gated-at.bofh.it> <tpCfT-87G-3@gated-at.bofh.it> <tpDlE-r8-11@gated-at.bofh.it> <tpDOF-Ur-9@gated-at.bofh.it> <txIet-2fd-9@gated-at.bofh.it> <ty0l4-5yM-27@gated-at.bofh.it> <ty0uL-5Cb-41@gated-at.bofh.it> <ty7wd-1ki-7@gated-at.bofh.it> <ty7FT-1nw-3@gated-at.bofh.it> <tyfN8-6Do-3@gated-at.bofh.it>
X-Original-To	Dmitry Vyukov <dvyukov@google.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=OKw3KgTF5v/ZNm7U9A05V1eOQHBbWzdsQ8RUsn8Ef8c=; b=WSNDz9h3SjcaqlXI5/JquOFvqOtr+1KEt0DW1kj8a4Kkdz48ZkCIfBdj4zaCVxhlHa G3WqNJYrxAcEC3MsRHy5u1Deq6kIdHGc4DxkboihDbUn929JBXdLSUmdQpI6PRk7Osnj Pozfd+fsE4nJwWzAicge5khzKk3QoaR9Ja+U9SZc1T7ZGUCQSp9DoSFMVWvYvrgAmqR4 TlADX5D0Bw3PLy9qsAArpmHbHcBZKIXNkGoMn3U/D/Xj/o/OLO/YlMZV8EFKuKdG4HD4 y1Lu+OYdFPd/eDCr1jTT0d73+N3AF42aZaLBkAOUAlaTSQ0bc9GDlsaWUgzfCiBpToZZ U+9A==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=OKw3KgTF5v/ZNm7U9A05V1eOQHBbWzdsQ8RUsn8Ef8c=; b=fzA+965IULv0Lbq5Hu/KN2eQjiwNCEXnoGgoY8YBXiNsTHLiVdsQRiyi7N6+drkp9P 9YZiZWCiRkd2dVSgIcEO1odvE/o+kaPKwhJmPdBEB48XWT4TUnPL/A9YiUcXShLE5kc1 EAs4kstRwV+k4FPX5eBprZQVi7D2zCkqRBrz1XUzaOFhMI3BN7V0FJ4UlqLZIti02c0S MFsE9FuLxz2/PgXEEx0LQC4kvknSq64sTzh+FWs6Ggxq53OWrWxUEAcCTxIUWir6NXlo 0+A/hu91NY36bqlEdZkc2sSBvRe2KKptNYjVFgfnT5PFpuUJ7KMLHnavodrktQGT8mCE N/oA==
X-Gm-Message-State	AN3rC/5UDRwUSPOpCmUmBSvwPHyHVhQuxODUUhEFOtLCBUDaMfS6vv6J Kdfx4i3kYx0DnPJGsYrpjME1lHJoSR49
X-Received	by 10.84.222.12 with SMTP id w12mr10140929pls.115.1492690203953; Thu, 20 Apr 2017 05:10:03 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	36
Organization	linux.* mail to news gateway
X-Original-Cc	David Ahern <dsa@cumulusnetworks.com>, Cong Wang <xiyou.wangcong@gmail.com>, Eric Dumazet <eric.dumazet@gmail.com>, Mahesh Bandewar <maheshb@google.com>, Eric Dumazet <edumazet@google.com>, David Miller <davem@davemloft.net>, Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>, James Morris <jmorris@namei.org>, Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>, Patrick McHardy <kaber@trash.net>, netdev <netdev@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>, syzkaller <syzkaller@googlegroups.com>
X-Original-Date	Thu, 20 Apr 2017 14:10:03 +0200
X-Original-Message-ID	<CAAeHK+zWO1COcZDp9q4eHP9YN9Qv8CXLOJu8dJgCbihcFSK3jg@mail.gmail.com>
X-Original-References	<CACT4Y+YrA45diWz_8f4St8oX6aTC1kuGXMUvniGRbqXSGwawZQ@mail.gmail.com> <CACT4Y+YpUZ+7f5bzPh1hATwUXaZaPTu4rYYdz0RY1MHA1WG3SA@mail.gmail.com> <328b1fa7-2d97-6ae3-3b87-e33a0d564ad9@cumulusnetworks.com> <CACT4Y+aQFe+M=ESuShQ4FYNWAd8CNEQ=0rW+aAB0P-tp=PpFyQ@mail.gmail.com> <CACT4Y+aQgM=9QMkyfcXF2B5gGidvL07JP_m_inNXTPXU22i=aA@mail.gmail.com> <CACT4Y+Yx1cgWCkC2c7bze1V1VaecgBfioMvKS2-FUeaRr4DGXg@mail.gmail.com> <CACT4Y+bcMz13ad2kLaZGvct5sQ+RDki0StnOEbz3exAa8=zxqQ@mail.gmail.com> <CACT4Y+Z6f4aOxMZW44WXdYEyDJbGBYLnjKsHBXfK800h+EkrxA@mail.gmail.com> <2270c1ca-9481-60c1-9c29-87669223bded@cumulusnetworks.com> <CACT4Y+aUROZgAczRfntp5Rgvzcypviz5ZWBPdE6MWSiO0-3jEg@mail.gmail.com> <CAAeHK+zx6W_yxnoEQ2Pc1AT4uLXqYZaoi5oQBeuCntdGS38TQg@mail.gmail.com> <580392d8-fa33-67bb-c5d6-27d262f1646a@cumulusnetworks.com> <CAAeHK+zZb=K4X9=NmSWQJL8bpgMbXoG+h4RasAyYDr+C5pkVYA@mail.gmail.com> <CAM_iQpXyDN5GD+QLmWgJSc0bqV0ViK5LxSdwAV3XsHWr6vLJ2Q@mail.gmail.com> <1dad955e-28c1-3f02-8876-90cce4a7d1f8@cumulusnetworks.com> <CACT4Y+amFHj1DV3pmj+eJVxg52+GLdE-fEin5M86dOKubea7DQ@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1627404

Show key headers only | View raw

On Thu, Apr 20, 2017 at 10:35 AM, Dmitry Vyukov <dvyukov@google.com> wrote:
> On Thu, Apr 20, 2017 at 1:51 AM, David Ahern <dsa@cumulusnetworks.com> wrote:
>> On 4/19/17 5:47 PM, Cong Wang wrote:
>>> On Wed, Apr 19, 2017 at 9:12 AM, Andrey Konovalov <andreyknvl@google.com> wrote:
>>>>
>>>> Anyway, I just finished simplifying the reproducer. Give this one a try.
>>>
>>> Thanks for providing such a minimal reproducer!
>>>
>>> The following patch could fix this crash, but I am not 100% sure if we should
>>> just clear these bits or reject them with an errno.
>>>
>>> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
>>> index 9db14189..cf524c2 100644
>>> --- a/net/ipv6/route.c
>>> +++ b/net/ipv6/route.c
>>> @@ -2086,7 +2086,7 @@ static struct rt6_info
>>> *ip6_route_info_create(struct fib6_config *cfg)
>>>         } else
>>>                 rt->rt6i_prefsrc.plen = 0;
>>>
>>> -       rt->rt6i_flags = cfg->fc_flags;
>>> +       rt->rt6i_flags = cfg->fc_flags & ~(RTF_PCPU | RTF_CACHE);
>>>
>>>  install_route:
>>>         rt->dst.dev = dev;
>>>
>>
>> I sent a patch returning EINVAL if RTF_PCPU is set in fc_flags
>
>
> Andrey, does it fix the other crashes?

No, still see them.

I'm working on reproducing those.

Thread

Re: net: heap out-of-bounds in  fib6_clean_node/rt6_fill_node/fib6_age/fib6_prune_clone David Ahern <dsa@cumulusnetworks.com> - 2017-04-19 18:10 +0200
  Re: net: heap out-of-bounds in fib6_clean_node/rt6_fill_node/fib6_age/fib6_prune_clone Andrey Konovalov <andreyknvl@google.com> - 2017-04-19 18:20 +0200
    Re: net: heap out-of-bounds in  fib6_clean_node/rt6_fill_node/fib6_age/fib6_prune_clone David Ahern <dsa@cumulusnetworks.com> - 2017-04-19 18:30 +0200
    Re: net: heap out-of-bounds in fib6_clean_node/rt6_fill_node/fib6_age/fib6_prune_clone Cong Wang <xiyou.wangcong@gmail.com> - 2017-04-20 01:50 +0200
      Re: net: heap out-of-bounds in  fib6_clean_node/rt6_fill_node/fib6_age/fib6_prune_clone David Ahern <dsa@cumulusnetworks.com> - 2017-04-20 02:00 +0200
        Re: net: heap out-of-bounds in fib6_clean_node/rt6_fill_node/fib6_age/fib6_prune_clone Dmitry Vyukov <dvyukov@google.com> - 2017-04-20 10:40 +0200
          Re: net: heap out-of-bounds in fib6_clean_node/rt6_fill_node/fib6_age/fib6_prune_clone Andrey Konovalov <andreyknvl@google.com> - 2017-04-20 14:20 +0200
            Re: net: heap out-of-bounds in fib6_clean_node/rt6_fill_node/fib6_age/fib6_prune_clone Andrey Konovalov <andreyknvl@google.com> - 2017-04-20 17:30 +0200
            Re: net: heap out-of-bounds in fib6_clean_node/rt6_fill_node/fib6_age/fib6_prune_clone Andrey Konovalov <andreyknvl@google.com> - 2017-04-20 17:40 +0200
              Re: net: heap out-of-bounds in fib6_clean_node/rt6_fill_node/fib6_age/fib6_prune_clone Andrey Konovalov <andreyknvl@google.com> - 2017-04-20 18:20 +0200
                Re: net: heap out-of-bounds in  fib6_clean_node/rt6_fill_node/fib6_age/fib6_prune_clone David Ahern <dsa@cumulusnetworks.com> - 2017-04-21 16:30 +0200
                Re: net: heap out-of-bounds in  fib6_clean_node/rt6_fill_node/fib6_age/fib6_prune_clone David Ahern <dsa@cumulusnetworks.com> - 2017-04-21 20:30 +0200
                Re: net: heap out-of-bounds in  fib6_clean_node/rt6_fill_node/fib6_age/fib6_prune_clone Eric Dumazet <eric.dumazet@gmail.com> - 2017-04-21 20:50 +0200
            Re: net: heap out-of-bounds in  fib6_clean_node/rt6_fill_node/fib6_age/fib6_prune_clone David Ahern <dsa@cumulusnetworks.com> - 2017-04-20 17:40 +0200

csiph-web