Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1627423

Re: [PATCH] timer: fix timer_migration to accept only 0 and 1

Show all headers | View raw

On Wed, 19 Apr 2017, Myungho Jung wrote:

> Error is not shown by setting invalid value to timer_migration. Valid
> values for timer_migration should be restricted to 0 and 1. Testcase for
> this bug is ltp/runpwtests06.

While I agree with the change, I disagree with the changelog. Where is the bug?

The timer code checks for timer_migration != 0 resp. == 0. So as long as
the value is != 0 it's enabled, if it's 0 it is disabled.

It's a correctness issue that we treat a sysctl which is basically a
boolean as such. Ideally we'd have: proc_doboolvec() for such cases and
convert all similar sysctls over to that.

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] timer: fix timer_migration to accept only 0 and 1 Myungho Jung <mhjungk@gmail.com> - 2017-04-20 00:30 +0200
  Re: [PATCH] timer: fix timer_migration to accept only 0 and 1 Thomas Gleixner <tglx@linutronix.de> - 2017-04-20 15:00 +0200
    Re: [PATCH] timer: fix timer_migration to accept only 0 and 1 Myungho Jung <mhjungk@gmail.com> - 2017-04-20 19:40 +0200
      Re: [PATCH] timer: fix timer_migration to accept only 0 and 1 Thomas Gleixner <tglx@linutronix.de> - 2017-04-20 19:50 +0200
        Re: [PATCH] timer: fix timer_migration to accept only 0 and 1 Myungho Jung <mhjungk@gmail.com> - 2017-04-20 20:10 +0200
  [tip:timers/core] timer/sysclt: Restrict timer migration sysctl  values to 0 and 1 tip-bot for Myungho Jung <tipbot@zytor.com> - 2017-04-20 15:20 +0200

csiph-web