Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1627276

Re: [PATCH] mmc: dw_mmc: hide clock message when card is resuming

From Jaehoon Chung <jh80.chung@samsung.com>
Newsgroups linux.kernel
Subject Re: [PATCH] mmc: dw_mmc: hide clock message when card is resuming
Date 2017-04-20 12:10 +0200
Message-ID <tyhcf-7D4-29@gated-at.bofh.it> (permalink)
References <tyhcf-7D4-31@gated-at.bofh.it> <txZfk-4Gn-29@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi Alexander,

On 04/19/2017 11:55 PM, Alexander Kochetkov wrote:
> Commit e9748e0364fe ("mmc: dw_mmc: force setup bus if active slots exist")
> made a change resulted in clock message appears every time the card is
> resuming (every 5 second in average). Add condition that previously used to
> print the message.

I think you are not using the latest kernel. which version do you use?

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ce69e2fea093b7fa3991c87849c4955cd47796c9

Could you check this?

Best Regards,
Jaehoon Chung

> 
> Fixes: e9748e0364fe ("mmc: dw_mmc: force setup bus if active slots exist")
> Signed-off-by: Alexander Kochetkov <al.kochet@gmail.com>
> ---
>  drivers/mmc/host/dw_mmc.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index 73db085..faaf2c1 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -1178,7 +1178,8 @@ static void dw_mci_setup_bus(struct dw_mci_slot *slot, bool force_clkinit)
>  
>  		if ((clock != slot->__clk_old &&
>  			!test_bit(DW_MMC_CARD_NEEDS_POLL, &slot->flags)) ||
> -			force_clkinit) {
> +		    (force_clkinit &&
> +			(slot->mmc->pm_flags & MMC_PM_KEEP_POWER))) {
>  			dev_info(&slot->mmc->class_dev,
>  				 "Bus speed (slot %d) = %dHz (slot req %dHz, actual %dHZ div = %d)\n",
>  				 slot->id, host->bus_hz, clock,
> 

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] mmc: dw_mmc: hide clock message when card is resuming Alexander Kochetkov <al.kochet@gmail.com> - 2017-04-19 17:00 +0200
  Re: [PATCH] mmc: dw_mmc: hide clock message when card is resuming Jaehoon Chung <jh80.chung@samsung.com> - 2017-04-20 12:10 +0200
    Re: [PATCH] mmc: dw_mmc: hide clock message when card is resuming Alexander Kochetkov <al.kochet@gmail.com> - 2017-04-20 16:00 +0200

csiph-web