Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1627308
| From | Takashi Iwai <tiwai@suse.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] ALSA: firewire-motu: mark trace helpers as __maybe_unused |
| Date | 2017-04-20 13:00 +0200 |
| Message-ID | <tyhYC-7U2-17@gated-at.bofh.it> (permalink) |
| References | <ty23w-6o6-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, 19 Apr 2017 19:51:29 +0200,
Arnd Bergmann wrote:
>
> Two functions were introduced for the purpose of tracing but cause warnings
> when tracing is disabled:
>
> sound/firewire/motu/amdtp-motu.c:284:13: error: 'copy_message' defined but not used [-Werror=unused-function]
> static void copy_message(u64 *frames, __be32 *buffer, unsigned int data_blocks,
> sound/firewire/motu/amdtp-motu.c:271:13: error: 'copy_sph' defined but not used [-Werror=unused-function]
> static void copy_sph(u32 *frames, __be32 *buffer, unsigned int data_blocks,
>
> Marking them as __maybe_unused will do the right thing here.
>
> Fixes: 17909c1b3058 ("ALSA: firewire-motu: add tracepoints for SPH in IEC 61883-1 fashion")
> Fixes: c6b0b9e65f09 ("ALSA: firewire-motu: add tracepoints for messages for unique protocol")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied, thanks.
Takashi
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] ALSA: firewire-motu: mark trace helpers as __maybe_unused Arnd Bergmann <arnd@arndb.de> - 2017-04-19 20:00 +0200
Re: [PATCH] ALSA: firewire-motu: mark trace helpers as __maybe_unused Takashi Iwai <tiwai@suse.de> - 2017-04-20 13:00 +0200
Re: [PATCH] ALSA: firewire-motu: mark trace helpers as __maybe_unused Takashi Iwai <tiwai@suse.de> - 2017-04-20 15:10 +0200
csiph-web