Re: [PATCH perf/urgent] perf tools: Fix the code to strip command name

From	Jiri Olsa <jolsa@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH perf/urgent] perf tools: Fix the code to strip command name
Date	2017-04-20 12:50 +0200
Message-ID	<tyhOV-7Qv-7@gated-at.bofh.it> (permalink)
References	<tygzw-7a4-7@gated-at.bofh.it> <tyhlT-7Gn-1@gated-at.bofh.it> <tyhFf-7N1-13@gated-at.bofh.it> <tyhOV-7Qv-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Apr 20, 2017 at 07:42:31PM +0900, Taeung Song wrote:
> 
> 
> On 04/20/2017 07:35 PM, Jiri Olsa wrote:
> > On Thu, Apr 20, 2017 at 07:17:34PM +0900, Taeung Song wrote:
> > > Hi Jiri,
> > > 
> > > On 04/20/2017 06:24 PM, Jiri Olsa wrote:
> > > > Recent commit broke command name strip in perf_event__get_comm_ids
> > > > function. It replaced left to right search for '\n' with rtrim,
> > > > which actually does right to left search. It occasionally caught
> > > > earlier '\n' and kept trash in the command name.
> > > 
> > > Sorry for my commit that have failings.
> > > 
> > > Could I know the command name in the above case ?
> > > The command name can have two '\n' ?
> > 
> > it's the next line in the status file.. parts of the Umask string
> > and 1 newline
> > 
> > Name:   systemd
> > Umask:  0000
> > State:  S (sleeping)
> > ...
> > 
> > I've already posted it in here:
> >   http://marc.info/?l=linuxppc-embedded&m=149200723316270&w=2
> > 
> > jirka
> > 
> 
> I understood it.
> Sorry for my mistake..

no worries.. we do plenty of those ;-)

jirka

Thread

[PATCH perf/urgent] perf tools: Fix the code to strip command name Jiri Olsa <jolsa@kernel.org> - 2017-04-20 11:30 +0200
  Re: [PATCH perf/urgent] perf tools: Fix the code to strip command  name Taeung Song <treeze.taeung@gmail.com> - 2017-04-20 12:20 +0200
    Re: [PATCH perf/urgent] perf tools: Fix the code to strip command  name Jiri Olsa <jolsa@redhat.com> - 2017-04-20 12:40 +0200
      Re: [PATCH perf/urgent] perf tools: Fix the code to strip command  name Taeung Song <treeze.taeung@gmail.com> - 2017-04-20 12:50 +0200
        Re: [PATCH perf/urgent] perf tools: Fix the code to strip command  name Jiri Olsa <jolsa@redhat.com> - 2017-04-20 12:50 +0200
  Re: [PATCH perf/urgent] perf tools: Fix the code to strip command  name Jiri Olsa <jolsa@redhat.com> - 2017-04-24 13:40 +0200
  Re: [PATCH perf/urgent] perf tools: Fix the code to strip command  name Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-04-24 17:50 +0200
    Re: [PATCH perf/urgent] perf tools: Fix the code to strip command  name Jiri Olsa <jolsa@redhat.com> - 2017-04-24 18:10 +0200
      Re: [PATCH perf/urgent] perf tools: Fix the code to strip command  name Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-04-24 18:30 +0200

csiph-web