Re: [PATCH] ASoC: fsl_asrc_dma: use correct direction enum type

From	Nicolin Chen <nicoleotsuka@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ASoC: fsl_asrc_dma: use correct direction enum type
Date	2017-04-20 08:50 +0200
Message-ID	<tye4G-5xb-7@gated-at.bofh.it> (permalink)
References	<tydV0-5tf-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Apr 19, 2017 at 11:36:07PM -0700, Stefan Agner wrote:
> The direction argument is of type enum dma_transfer_direction, and
> not enum dma_data_direction. The enumeration values are the same
> so this did not had an effect in practise.
> 
> Signed-off-by: Stefan Agner <stefan@agner.ch>

Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>

Thanks

> ---
>  sound/soc/fsl/fsl_asrc_dma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/fsl/fsl_asrc_dma.c b/sound/soc/fsl/fsl_asrc_dma.c
> index dc30d780f874..282d841840b1 100644
> --- a/sound/soc/fsl/fsl_asrc_dma.c
> +++ b/sound/soc/fsl/fsl_asrc_dma.c
> @@ -76,7 +76,7 @@ static int fsl_asrc_dma_prepare_and_submit(struct snd_pcm_substream *substream)
>  			pair->dma_chan[!dir], runtime->dma_addr,
>  			snd_pcm_lib_buffer_bytes(substream),
>  			snd_pcm_lib_period_bytes(substream),
> -			dir == OUT ? DMA_TO_DEVICE : DMA_FROM_DEVICE, flags);
> +			dir == OUT ? DMA_MEM_TO_DEV : DMA_DEV_TO_MEM, flags);
>  	if (!pair->desc[!dir]) {
>  		dev_err(dev, "failed to prepare slave DMA for Front-End\n");
>  		return -ENOMEM;
> -- 
> 2.12.2
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ASoC: fsl_asrc_dma: use correct direction enum type Stefan Agner <stefan@agner.ch> - 2017-04-20 08:40 +0200
  Re: [PATCH] ASoC: fsl_asrc_dma: use correct direction enum type Nicolin Chen <nicoleotsuka@gmail.com> - 2017-04-20 08:50 +0200

csiph-web