Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1627010

Re: [PATCH v3 1/5] dt-bindings: gpu: add bindings for the ARM Mali Midgard GPU

Show all headers | View raw

Hi Heiko,

On 19/04/17 10:02, Heiko Stuebner wrote:
> Am Mittwoch, 19. April 2017, 09:06:17 CEST schrieb Guillaume Tucker:
>> diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt
>> new file mode 100644
>> index 000000000000..917c4f8d178f
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt
>> @@ -0,0 +1,57 @@
>> +ARM Mali Midgard GPU
>> +====================
>> +
>> +Required properties:
>> +
>> +- compatible :
>> +  * Must be one of the following:
>> +    + "arm,mali-t60x"
>> +    + "arm,mali-t62x"
>> +    + "arm,mali-t720"
>> +    + "arm,mali-t760"
>> +    + "arm,mali-t820"
>> +    + "arm,mali-t830"
>> +    + "arm,mali-t860"
>> +    + "arm,mali-t880"
>> +  * And, optionally, one of the vendor specific compatible:
>> +    + "amlogic,meson-gxm-mali"
>
> Please add a "rockchip,rk3288-mali" as well :-) , as I don't trust that the
> generic compatible will be enough for all time and having that already
> defined makes fixing the per soc things later a lot easier.

Sure, will do in patch v4.

>> +
>> +- reg : Physical base address of the device and length of the register area.
>> +
>> +- interrupts : Contains the three IRQ lines required by Mali Midgard devices.
>> +
>> +- interrupt-names : Contains the names of IRQ resources in the order they were
>> +  provided in the interrupts property. Must contain: "job", "mmu", "gpu".
>> +
>> +
>> +Optional properties:
>> +
>> +- clocks : Phandle to clock for the Mali Midgard device.
>> +
>> +- mali-supply : Phandle to regulator for the Mali device. Refer to
>> +  Documentation/devicetree/bindings/regulator/regulator.txt for details.
>> +
>> +- operating-points : Refer to Documentation/devicetree/bindings/power/opp.txt
>> +  for details.

So I can simply change that to operating-points-v2.  Both
versions can be used in practice but it sounds like
operating-points can just be ignored in this binding's
documentation.  Could you please confirm?

Thanks,
Guillaume

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/5] Add ARM Mali Midgard device tree bindings and gpu node for rk3288 Guillaume Tucker <guillaume.tucker@collabora.com> - 2017-04-19 10:10 +0200
  [PATCH v3 5/5] ARM: dts: rockchip: enable ARM Mali GPU on rk3288-veyron Guillaume Tucker <guillaume.tucker@collabora.com> - 2017-04-19 10:10 +0200
  [PATCH v3 1/5] dt-bindings: gpu: add bindings for the ARM Mali Midgard GPU Guillaume Tucker <guillaume.tucker@collabora.com> - 2017-04-19 10:10 +0200
    Re: [PATCH v3 1/5] dt-bindings: gpu: add bindings for the ARM Mali Midgard GPU Heiko Stuebner <heiko@sntech.de> - 2017-04-19 11:10 +0200
      Re: [PATCH v3 1/5] dt-bindings: gpu: add bindings for the ARM Mali  Midgard GPU Guillaume Tucker <guillaume.tucker@collabora.com> - 2017-04-20 08:00 +0200
  [PATCH v3 2/5] ARM: dts: rockchip: add ARM Mali GPU node for rk3288 Guillaume Tucker <guillaume.tucker@collabora.com> - 2017-04-19 10:10 +0200
    Re: [PATCH v3 2/5] ARM: dts: rockchip: add ARM Mali GPU node for rk3288 Heiko Stuebner <heiko@sntech.de> - 2017-04-19 11:00 +0200
      Re: [PATCH v3 2/5] ARM: dts: rockchip: add ARM Mali GPU node for  rk3288 Guillaume Tucker <guillaume.tucker@collabora.com> - 2017-04-20 07:50 +0200
        Re: [PATCH v3 2/5] ARM: dts: rockchip: add ARM Mali GPU node for rk3288 Heiko Stuebner <heiko@sntech.de> - 2017-04-20 08:50 +0200
  [PATCH v3 4/5] ARM: dts: rockchip: enable ARM Mali GPU on rk3288-firefly Guillaume Tucker <guillaume.tucker@collabora.com> - 2017-04-19 10:20 +0200
  [PATCH v3 3/5] ARM: dts: rockchip: enable ARM Mali GPU on rk3288-rock2-som Guillaume Tucker <guillaume.tucker@collabora.com> - 2017-04-19 10:20 +0200

csiph-web