Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1626954

Re: [PATCH -v2 0/9] mm: make movable onlining suck less

Path csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From Dan Williams <dan.j.williams@intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH -v2 0/9] mm: make movable onlining suck less
Date Thu, 20 Apr 2017 05:40:01 +0200
Message-ID <tyb6N-3Js-5@gated-at.bofh.it> (permalink)
References <tuFmO-8iD-7@gated-at.bofh.it> <tv7sJ-1pf-5@gated-at.bofh.it> <txmQF-617-1@gated-at.bofh.it> <txvAC-3i3-11@gated-at.bofh.it> <txEue-8r4-7@gated-at.bofh.it> <txHs6-1Kl-27@gated-at.bofh.it>
X-Original-To Michal Hocko <mhocko@kernel.org>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=8WSezLU06yF5FZNx4m88V/rhL9YHOaX93FPIo4zWnlM=; b=IyMm6IpxwUC1UfYB3D1I9inYnxTvfUAN5RWeFtqiEAKaYonjd9j/5rz2LKpJjh7D49 TUnXMpHQRvOh2UpGLoKI2poSuVRofOreAAkfM1MVlKJffdUkF3EabmSzio3dUgnG9dM4 InvFHQ+jUimEFMkM3CHYRaXQr9pYz2Q8/u8KnHsmF7rW5PSdJ42hgZzu1PswbKb6wkxj 9ulOZiu4svWtavasBZnfl8huELgHk2Z4aKusuE23f4ziDGWwxcI9nX4JRm9FcectUpxQ 1WTivrpyz8cVo7+Tz4oO6OG8MALDq4sOKslX90s5vXrxro1P22+5k1aSYHmKC881RnnS BtYA==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=8WSezLU06yF5FZNx4m88V/rhL9YHOaX93FPIo4zWnlM=; b=OX1lKWSjDdO4Aka8TBDdpPr3Y6d8fQrIt6HFjIzEFxap1khdpJRbdqf9UNM57SE1U4 mRTmn/zT5LI6SJuD5mIUjnC+2sCwnWe82zKiNTHNJ24gaFk/PAj+8qwj8wfOJOaYgkhP DIWvvDpWdbqPqhl+T/TcEciCzbokCxzI5xxdmu17W/sR1ODbVHIlf0BrRyCSzFvNrH8g Pq5JP9nMyVDmwI6hy35uoAvoClU8CkfZvw/DmPjVVPoRSooH4TXQup6uq/xWb8Tlok+a UWIW4oN6TzAfiMHpvYBgqS9hHWZWp4sBFtX6geKY+CMOB1XESxcUFNLeHR6fkeNH3Tsu JhOQ==
X-Gm-Message-State AN3rC/56vqT12gDfWUOKJe+aQ73CTWE8wxNuHWu/DGyc7v/PEQjdoJt1 ZwEaCYZXJIfpZuEhr5VDNGqsw6e/4w==
X-Received by 10.28.228.4 with SMTP id b4mr916633wmh.119.1492659429300; Wed, 19 Apr 2017 20:37:09 -0700 (PDT)
MIME-Version 1.0
X-Google-Sender-Auth cOP4oymtWGtcCn9kN_bWNHlwQWU
Content-Type text/plain; charset=UTF-8
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 86
Organization linux.* mail to news gateway
X-Original-Cc linux-mm <linux-mm@kvack.org>, Andrew Morton <akpm@linux-foundation.org>, Mel Gorman <mgorman@suse.de>, Vlastimil Babka <vbabka@suse.cz>, Andrea Arcangeli <aarcange@redhat.com>, Jerome Glisse <jglisse@redhat.com>, Reza Arbab <arbab@linux.vnet.ibm.com>, Yasuaki Ishimatsu <yasu.isimatu@gmail.com>, qiuxishi@huawei.com, Kani Toshimitsu <toshi.kani@hpe.com>, slaoub@gmail.com, Joonsoo Kim <js1304@gmail.com>, Andi Kleen <ak@linux.intel.com>, David Rientjes <rientjes@google.com>, Daniel Kiper <daniel.kiper@oracle.com>, Igor Mammedov <imammedo@redhat.com>, Vitaly Kuznetsov <vkuznets@redhat.com>, LKML <linux-kernel@vger.kernel.org>, Heiko Carstens <heiko.carstens@de.ibm.com>, Lai Jiangshan <laijs@cn.fujitsu.com>, Martin Schwidefsky <schwidefsky@de.ibm.com>, Tobias Regnery <tobias.regnery@gmail.com>
X-Original-Date Wed, 19 Apr 2017 20:37:08 -0700
X-Original-Message-ID <CAA9_cmdJVaYg_KYPqRrnLe2V4rw7xPhzyCtVOp2pd+65hMX1Wg@mail.gmail.com>
X-Original-References <20170410110351.12215-1-mhocko@kernel.org> <20170411170317.GB21171@dhcp22.suse.cz> <CAA9_cmdrNZkOByvSecmocqs=6o8ZP5bz+Zx6NrwqjU66C=5Y4w@mail.gmail.com> <20170418071456.GD22360@dhcp22.suse.cz> <CAA9_cmfxa8QO=8-FeXWAg7iBrGh0LrZM4C=vWA5xb2ADLtO4Rw@mail.gmail.com> <20170418195435.GB20671@dhcp22.suse.cz>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1626954

Show key headers only | View raw


On Tue, Apr 18, 2017 at 12:54 PM, Michal Hocko <mhocko@kernel.org> wrote:
> On Tue 18-04-17 09:42:57, Dan Williams wrote:
>> On Tue, Apr 18, 2017 at 12:14 AM, Michal Hocko <mhocko@kernel.org> wrote:
>> > On Mon 17-04-17 14:51:12, Dan Williams wrote:
>> >> On Tue, Apr 11, 2017 at 10:03 AM, Michal Hocko <mhocko@kernel.org> wrote:
>> >> > All the reported issue seem to be fixed and pushed to my git tree
>> >> > attempts/rewrite-mem_hotplug branch. I will wait a day or two for more
>> >> > feedback and then repost for the inclusion. I would really appreaciate
>> >> > more testing/review!
>> >>
>> >> This still seems to be based on 4.10? It's missing some block-layer
>> >> fixes and other things that trigger failures in the nvdimm unit tests.
>> >> Can you rebase to a more recent 4.11-rc?
>> >
>> > OK, I will rebase on top of linux-next. This has been based on mmotm
>> > tree so far. Btw. is there anything that would change the current
>> > implementation other than small context tweaks? In other words, do you
>> > see any issues with the current implementation regarding nvdimm's
>> > ZONE_DEVICE usage?
>>
>> I don't foresee any issues, but I wanted to be able to run the latest
>> test suite to be sure.
>
> OK, the rebase on top of the current linux-next is in my git tree [1]
> attempts/rewrite-mem_hotplug branch. I will post the full series
> tomorrow hopefully.
>
> [1] git://git.kernel.org/pub/scm/linux/kernel/git/mhocko/mm.git


I'm hitting the following with the "device-dax" unit test [1]. Does
not look like your changes, but I'm kicking off a bisect between
v4.11-rc7 and this branch tip.

[1]: https://github.com/pmem/ndctl/blob/master/test/device-dax.c

---

[  547.047430] BUG: unable to handle kernel paging request at ffff880001000000
[  547.048954] IP: native_set_pte_at+0x1/0x10
[  547.049967] PGD 3197067
[  547.049968] P4D 3197067
[  547.050779] PUD 3198067
[  547.051589] PMD 33ff00067
[  547.052401] PTE 8000000001000161
[  547.053237]
[  547.054819] Oops: 0003 [#1] SMP DEBUG_PAGEALLOC
[  547.055907] Dumping ftrace buffer:
[  547.056864]    (ftrace buffer empty)
[  547.057815] Modules linked in: nd_blk(O) ip6t_rpfilter ip6t_REJECT
nf_reject_ipv6 xt_conntrack ebtable_nat ebtable_broute bridge stp llc
ip6table_nat nf_conntrack_ipv6 nf_defrag_ipv6 nf_n
at_ipv6 ip6table_mangle ip6table_raw ip6table_security iptable_nat
nf_conntrack_ipv4 nf_defrag_ipv4 nf_nat_ipv4 nf_nat nf_conntrack
iptable_mangle iptable_raw iptable_security ebtable_filter
 ebtables ip6table_filter ip6_tables crct10dif_pclmul crc32_pclmul
crc32c_intel ghash_clmulni_intel dax_pmem(O) nd_pmem(O) dax(O)
nd_btt(O) nfit(O) nd_e820(O) tpm_tis libnvdimm(O) serio_raw
tpm_tis_core tpm nfit_test_iomap(O) nfsd nfs_acl [last unloaded: nfit_test]
[  547.069034] CPU: 17 PID: 9526 Comm: lt-ndctl Tainted: G           O
   4.11.0-rc7-next-20170418+ #34
[  547.071122] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996),
BIOS 1.9.3-1.fc25 04/01/2014
[  547.073163] task: ffff880322f518c0 task.stack: ffffc90002f08000
[  547.074433] RIP: 0010:native_set_pte_at+0x1/0x10
[  547.075523] RSP: 0018:ffffc90002f0bb90 EFLAGS: 00010246
[  547.076703] RAX: 0000000000000000 RBX: ffff880200000000 RCX: 0000000000000000
[  547.078129] RDX: ffff880001000000 RSI: ffff880200000000 RDI: ffffffff820892e0
[  547.079549] RBP: ffffc90002f0bba8 R08: 0000000000000000 R09: ffffffff81ec7264
[  547.080969] R10: ffffc90002f0bb28 R11: ffff880322f518c0 R12: ffff880200200000
[  547.082389] R13: ffff88033ff00000 R14: ffff880200001000 R15: ffff880200000000
[  547.083816] FS:  00007fc08d585380(0000) GS:ffff880336040000(0000)
knlGS:0000000000000000
[  547.085777] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[  547.087013] CR2: ffff880001000000 CR3: 000000019fe1f000 CR4: 00000000000406e0
[  547.091667] Call Trace:
[  547.092466]  ? pte_clear.constprop.18+0x26/0x2b
[  547.093563]  remove_pagetable+0x4af/0x783
[  547.094582]  arch_remove_memory+0xa2/0xc0
[  547.095598]  devm_memremap_pages_release+0xde/0x330
[  547.096726]  release_nodes+0x16d/0x2b0
[  547.097702]  devres_release_all+0x3c/0x50
[  547.098726]  device_release_driver_internal+0x16d/0x210
[  547.099900]  device_release_driver+0x12/0x20
[  547.100949]  unbind_store+0x10f/0x160
[

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

Re: [PATCH -v2 0/9] mm: make movable onlining suck less Michal Hocko <mhocko@kernel.org> - 2017-04-11 19:10 +0200
  Re: [PATCH -v2 0/9] mm: make movable onlining suck less Dan Williams <dan.j.williams@gmail.com> - 2017-04-18 00:00 +0200
    Re: [PATCH -v2 0/9] mm: make movable onlining suck less Michal Hocko <mhocko@kernel.org> - 2017-04-18 09:20 +0200
      Re: [PATCH -v2 0/9] mm: make movable onlining suck less Dan Williams <dan.j.williams@gmail.com> - 2017-04-18 18:50 +0200
        Re: [PATCH -v2 0/9] mm: make movable onlining suck less Michal Hocko <mhocko@kernel.org> - 2017-04-18 22:00 +0200
          Re: [PATCH -v2 0/9] mm: make movable onlining suck less Dan Williams <dan.j.williams@intel.com> - 2017-04-20 05:40 +0200

csiph-web