Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1628787

Re: [PATCH] hwmon: (ibmpowernv) Add min/max attributes and current sensors

Show all headers | View raw

Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> writes:
> On 04/21/2017 05:17 PM, Cédric Le Goater wrote:
>> On 04/21/2017 06:31 AM, Shilpasri G Bhat wrote:
>>> diff --git a/drivers/hwmon/ibmpowernv.c b/drivers/hwmon/ibmpowernv.c
>>> index 6d2e660..1f329fa8 100644
>>> --- a/drivers/hwmon/ibmpowernv.c
>>> +++ b/drivers/hwmon/ibmpowernv.c
>>> @@ -65,7 +66,8 @@ enum sensors {
>>>  	{"fan", "ibm,opal-sensor-cooling-fan"},
>>>  	{"temp", "ibm,opal-sensor-amb-temp"},
>>>  	{"in", "ibm,opal-sensor-power-supply"},
>>> -	{"power", "ibm,opal-sensor-power"}
>>> +	{"power", "ibm,opal-sensor-power"},
>>> +	{"curr"}, /* Follows newer device tree compatible ibm,opal-sensor */
>> 
>> why isn't there a compatible string ? 
>
> Skiboot exports "ibm,opal-sensor" as compatible string for all the inband
> sensors. Now if I define that as the compatible string here, then all the
> sensors would get identified as "curr" type of sensor by the driver.

So fix it in skiboot?

cheers

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] hwmon: (ibmpowernv) Add min/max attributes and current sensors Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> - 2017-04-21 06:40 +0200
  Re: [PATCH] hwmon: (ibmpowernv) Add min/max attributes and current  sensors Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> - 2017-04-21 14:50 +0200
    Re: [PATCH] hwmon: (ibmpowernv) Add min/max attributes and current sensors Michael Ellerman <mpe@ellerman.id.au> - 2017-04-22 08:20 +0200
  Re: [PATCH] hwmon: (ibmpowernv) Add min/max attributes and current  sensors Cédric Le Goater <clg@kaod.org> - 2017-04-21 21:10 +0200

csiph-web