[PATCH] tracing: Use cpumask_available() to check if cpumask variable may be used

From	Matthias Kaehlcke <mka@chromium.org>
Newsgroups	linux.kernel
Subject	[PATCH] tracing: Use cpumask_available() to check if cpumask variable may be used
Date	2017-04-22 01:50 +0200
Message-ID	<tyQtk-3Gv-7@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

This fixes the following clang warning:

kernel/trace/trace.c:3231:12: warning: address of array 'iter->started'
  will always evaluate to 'true' [-Wpointer-bool-conversion]
        if (iter->started)

Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
Dependencies:
- "cpumask: Add helper cpumask_available()"
  - git.kernel.org tip master f7e30f01a9e2
  - https://patchwork.kernel.org/patch/9678159/

 kernel/trace/trace.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index d484452ae648..95eeefc08605 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -3222,13 +3222,14 @@ static void test_cpu_buff_start(struct trace_iterator *iter)
 	if (!(iter->iter_flags & TRACE_FILE_ANNOTATE))
 		return;
 
-	if (iter->started && cpumask_test_cpu(iter->cpu, iter->started))
+	if (cpumask_available(iter->started) &&
+	    cpumask_test_cpu(iter->cpu, iter->started))
 		return;
 
 	if (per_cpu_ptr(iter->trace_buffer->data, iter->cpu)->skipped_entries)
 		return;
 
-	if (iter->started)
+	if (cpumask_available(iter->started))
 		cpumask_set_cpu(iter->cpu, iter->started);
 
 	/* Don't print started cpu buffer for the first entry of the trace */
-- 
2.12.2.816.g2cccc81164-goog

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] tracing: Use cpumask_available() to check if cpumask variable may be used Matthias Kaehlcke <mka@chromium.org> - 2017-04-22 01:50 +0200

csiph-web