Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1628685

[PATCH 2/5] lightnvm: pblk: fix bad error check

From "Javier González" <jg@lightnvm.io>
Newsgroups linux.kernel
Subject [PATCH 2/5] lightnvm: pblk: fix bad error check
Date 2017-04-22 01:40 +0200
Message-ID <tyQjD-3De-9@gated-at.bofh.it> (permalink)
References <tyQjD-3De-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Fix bad error check

Fixes: a4bd217b4326 "lightnvm: physical block device (pblk) target"

Signed-off-by: Javier González <javier@cnexlabs.com>
---
 drivers/lightnvm/pblk-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
index 7065658..7eb62ec 100644
--- a/drivers/lightnvm/pblk-core.c
+++ b/drivers/lightnvm/pblk-core.c
@@ -1273,7 +1273,7 @@ struct pblk_line *pblk_line_replace_data(struct pblk *pblk)
 retry_setup:
 	if (!pblk_line_set_metadata(pblk, new, cur)) {
 		new = pblk_line_retry(pblk, new);
-		if (new)
+		if (!new)
 			return NULL;
 
 		goto retry_setup;
-- 
2.7.4

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH 2/5] lightnvm: pblk: fix bad error check "Javier González" <jg@lightnvm.io> - 2017-04-22 01:40 +0200
  Re: [PATCH 2/5] lightnvm: pblk: fix bad error check Matias Bjørling <mb@lightnvm.io> - 2017-04-22 11:00 +0200

csiph-web