Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1628657

Re: [PATCH v2 8/8] platform: x86: intel_bxtwc_tmu: remove first level irq unmask

From sathyanarayanan kuppuswamy <sathyanarayanan.kuppuswamy@linux.intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2 8/8] platform: x86: intel_bxtwc_tmu: remove first level irq unmask
Date 2017-04-22 00:40 +0200
Message-ID <tyPnA-355-11@gated-at.bofh.it> (permalink)
References <twiP7-7rl-3@gated-at.bofh.it> <twiP7-7rl-1@gated-at.bofh.it> <tyOUy-2RV-17@gated-at.bofh.it>
Organization Intel

Show all headers | View raw


Hi Darren,

Thanks for the review.


On 04/21/2017 03:00 PM, Darren Hart wrote:
> On Fri, Apr 14, 2017 at 04:26:00PM -0700, sathyanarayanan.kuppuswamy@linux.intel.com wrote:
>> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
>>
>> Currently in WCOVE PMIC mfd driver, all second level irq chips
> By currently I believe you mean after the earlier patch in this series is
> applied, correct?
Yes.
> This one is dependent on the previous one?
Yes, one of my previous patch in this series fixes this problem in MFD 
driver.
>
>> are chained to the respective first level irqs. So there is no
>> need for explicitly unmasking the first level irq in this
>> driver. This patches removes this level 1 irq unmask support.
>>
>> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
> For platform drivers x86:
>
> Reviewed-by: Darren Hart (VMware) <dvhart@infradead.org>
>
> Are you working with a specific maintainers to pull this in as a series?
Thanks for brining it up. I was planning to ask either Andy or Lee 
regarding this issue after all patches in the series are reviewed.
> With so
> many subsystems, we need to coordinate to make sure we don't make a mess for
> Linus. Given the interdependencies, I'd recommend someone pull the series in as
> a whole - maybe into MFD? Lee, do you have a preference?
>

-- 
Sathyanarayanan Kuppuswamy
Android kernel developer

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 8/8] platform: x86: intel_bxtwc_tmu: remove first level irq unmask sathyanarayanan.kuppuswamy@linux.intel.com - 2017-04-15 01:30 +0200
  Re: [PATCH v2 8/8] platform: x86: intel_bxtwc_tmu: remove first  level irq unmask Darren Hart <dvhart@infradead.org> - 2017-04-22 00:10 +0200
    Re: [PATCH v2 8/8] platform: x86: intel_bxtwc_tmu: remove first level  irq unmask sathyanarayanan kuppuswamy          <sathyanarayanan.kuppuswamy@linux.intel.com> - 2017-04-22 00:40 +0200
      Re: [PATCH v2 8/8] platform: x86: intel_bxtwc_tmu: remove first level  irq unmask Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-04-22 05:00 +0200
        Re: [PATCH v2 8/8] platform: x86: intel_bxtwc_tmu: remove first  level irq unmask Lee Jones <lee.jones@linaro.org> - 2017-04-24 11:30 +0200
          Re: [PATCH v2 8/8] platform: x86: intel_bxtwc_tmu: remove first level  irq unmask Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-04-24 11:50 +0200
            Re: [PATCH v2 8/8] platform: x86: intel_bxtwc_tmu: remove first  level irq unmask Lee Jones <lee.jones@linaro.org> - 2017-04-24 14:30 +0200
    Re: [PATCH v2 8/8] platform: x86: intel_bxtwc_tmu: remove first  level irq unmask Lee Jones <lee.jones@linaro.org> - 2017-04-24 11:30 +0200

csiph-web