Re: [PATCH] lightnvm: propagate pblk_init return to userspace

Path	csiph.com!news.redatomik.org!weretis.net!feeder4.news.weretis.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Javier González <jg@lightnvm.io>
Newsgroups	linux.kernel
Subject	Re: [PATCH] lightnvm: propagate pblk_init return to userspace
Date	Fri, 21 Apr 2017 21:30:02 +0200
Message-ID	<tyLDk-LM-29@gated-at.bofh.it> (permalink)
References	<typ06-3Ua-19@gated-at.bofh.it>
X-Original-To	Rakesh Pandit <rakesh@tuxera.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=lightnvm-io.20150623.gappssmtp.com; s=20150623; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=7A/cvsvtwk4tLUeSv46B0SGW/54TTEV76Ex7zNfR6PA=; b=nyQ95bkELH5YSb5+aSF/xd9Byt3yXShu2Ofi8IVPjYarVNgEZm/ucoj2mwKVTSslyx w4gF7nImf7unwQQ/OqAffdOXoEKoROrFSmJG1wetCWoIxVYqtc0P9np8eFYCepTqCAYt 5D5rBgxdiMV0Y/2ljXRO4iWoa0+JdW5UjjnwBPpQYoJ8KFS1mlUsea523Svy/wyaCeae YTHmm8S7XYWmN0GAlqmr4t9El7L/BHR7zNa7qU6h2uqXytVHpJGt38LF4kdYahPBKLf8 Qz9gfZ04bl641bLPr3kmRN5KxGaZZpFjc8ycEc+5SD18g6UZIylmWY+x0UL0JRrtYDJH kjXQ==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=7A/cvsvtwk4tLUeSv46B0SGW/54TTEV76Ex7zNfR6PA=; b=JFRLc8qxF9ogsXRZpZmpNfc2+AwdW+Lxwi3Doksjs8RDzFZf9wnR2yU8hI43uR6UcP s95Jn7/crH2Kdovqm1A1RYWNk2Pz77kXUF4TxhdSeNvSzHNRNAe9XicY0iJX6ESBuPSc AX0fnUf6YmethfvkWXbxAK39WdmOM1iTKkBc56EsoCZg3lSW7hnlTSAaQJM7Xzelv8GJ nEmWmPfwOH2GRjHYPKvJ+766Ndzdd+hwWrT96DKV7V9RycSL5bIgZEDUcv/UlUf9d7M1 /OtX61XiSHZ6cPh99BkkLlPoqzrigoh0gLdUi8tHGI23xRsH7iVCw8w9HPkgGddSSHKe wE7A==
X-Gm-Message-State	AN3rC/4Nh6kbxfI0XVcVuiuo2C8vxBZRvt7NcK8iilFLBlzXlmzsO2iH 7Pf/C7vwzW1pzQ==
X-Received	by 10.80.179.24 with SMTP id q24mr60747edd.27.1492787273591; Fri, 21 Apr 2017 08:07:53 -0700 (PDT)
Content-Type	multipart/signed; boundary="Apple-Mail=_A62A987E-1F9B-473C-8C4B-C64030F5D14B"; protocol="application/pgp-signature"; micalg=pgp-sha512
MIME-Version	1.0 (Mac OS X Mail 10.3 \(3273\))
X-Mailer	Apple Mail (2.3273)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	52
Organization	linux.* mail to news gateway
X-Original-Cc	Matias Bjørling <mb@lightnvm.io>, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Fri, 21 Apr 2017 17:07:50 +0200
X-Original-Message-ID	<F1FB4E37-23D4-4E6B-9310-78FA4699556C@lightnvm.io>
X-Original-References	<20170420182356.GA7866@hercules.tuxera.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1628534

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

> On 20 Apr 2017, at 20.23, Rakesh Pandit <rakesh@tuxera.com> wrote:
> 
> From userspace calling ioctl(NVM_DEV_CREATE) was returning ENOMEM for
> invalid arguments even though pblk (pblk_init) was returning correctly
> -EINVAL to nvm_create_tgt inside core.  This patch propagates the
> correct return value to userspace.
> 
> Because pblk was introduced recently this only needs to go in 4.12.
> 
> Fixes: a4bd217b4326 ("lightnvm: physical block device (pblk) target")
> Signed-off-by: Rakesh Pandit <rakesh@tuxera.com>
> 

Looks good.

Reviewed-by: Javier González <javier@cnexlabs.com>

Javier

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] lightnvm: propagate pblk_init return to userspace Rakesh Pandit <rakesh@tuxera.com> - 2017-04-20 20:30 +0200
  Re: [PATCH] lightnvm: propagate pblk_init return to userspace Matias Bjørling <mb@lightnvm.io> - 2017-04-21 20:40 +0200
    Re: [PATCH] lightnvm: propagate pblk_init return to userspace Jens Axboe <axboe@kernel.dk> - 2017-04-21 20:50 +0200
  Re: [PATCH] lightnvm: propagate pblk_init return to userspace Javier González <jg@lightnvm.io> - 2017-04-21 21:30 +0200

csiph-web