Re: [PATCH] bus: fsl-mc: dpio: fix alter FQ state command

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] bus: fsl-mc: dpio: fix alter FQ state command
Date	2017-04-21 19:10 +0200
Message-ID	<tyKef-8vc-53@gated-at.bofh.it> (permalink)
References	<tyGX0-6mH-23@gated-at.bofh.it> <tyGX0-6mH-21@gated-at.bofh.it> <tyHgm-6ts-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Apr 21, 2017 at 01:50:24PM +0000, Horia Geantă wrote:
> Let me know whether keeping code similar would be preferred or not.
> 

Keeping the code similar to the surrounding is never a valid argument
but especially not in staging/.  If only 1 line is nice in the whole
file, at least that's better than nothing.

regards,
dan carpenter

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] bus: fsl-mc: dpio: fix alter FQ state command Stuart Yoder <stuyoder@gmail.com> - 2017-04-21 15:40 +0200
  Re: [PATCH] bus: fsl-mc: dpio: fix alter FQ state command Horia Geantă <horia.geanta@nxp.com> - 2017-04-21 16:00 +0200
    Re: [PATCH] bus: fsl-mc: dpio: fix alter FQ state command Dan Carpenter <dan.carpenter@oracle.com> - 2017-04-21 19:10 +0200

csiph-web