Re: [PATCH v13 03/10] mux: minimal mux subsystem and gpio-based mux controller

From	Philipp Zabel <p.zabel@pengutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v13 03/10] mux: minimal mux subsystem and gpio-based mux controller
Date	2017-04-21 16:20 +0200
Message-ID	<tyHzJ-6Pl-47@gated-at.bofh.it> (permalink)
References	<txwQ2-3Wq-21@gated-at.bofh.it> <txwQ2-3Wq-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Peter,

On Thu, 2017-04-13 at 18:43 +0200, Peter Rosin wrote:
[...]
> +int mux_control_select(struct mux_control *mux, int state)

state could be unsigned int for the consumer facing API.

> +{
> +	int ret;

And mux_control_select should check that (0 <= state < mux->states).

regards
Philipp

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v13 03/10] mux: minimal mux subsystem and gpio-based mux  controller Philipp Zabel <p.zabel@pengutronix.de> - 2017-04-21 16:20 +0200

csiph-web