Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1628065

[PATCH v2] dmaengine: sun4i: fix invalid argument

From Mason <slash.tmp@free.fr>
Newsgroups linux.kernel
Subject [PATCH v2] dmaengine: sun4i: fix invalid argument
Date 2017-04-21 10:50 +0200
Message-ID <tyCqm-3El-31@gated-at.bofh.it> (permalink)
References <tyt3H-6m1-1@gated-at.bofh.it> <tyBDX-39t-11@gated-at.bofh.it> <tyBND-3rQ-15@gated-at.bofh.it> <tyC6Z-3xY-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>

The "pchans_used" field is an unsigned long array.

for_each_clear_bit_from() expects an unsigned long pointer,
not an array address.

$ make C=2 drivers/dma/sun4i-dma.o
  CHECK   drivers/dma/sun4i-dma.c
drivers/dma/sun4i-dma.c:241:9: warning: incorrect type in argument 1 (different base types)
drivers/dma/sun4i-dma.c:241:9:    expected unsigned long const *p
drivers/dma/sun4i-dma.c:241:9:    got unsigned long ( *<noident> )[1]

Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
---
 drivers/dma/sun4i-dma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/sun4i-dma.c b/drivers/dma/sun4i-dma.c
index 57aa227bfadb..f4ed3f17607c 100644
--- a/drivers/dma/sun4i-dma.c
+++ b/drivers/dma/sun4i-dma.c
@@ -238,7 +238,7 @@ static struct sun4i_dma_pchan *find_and_use_pchan(struct sun4i_dma_dev *priv,
 	}
 
 	spin_lock_irqsave(&priv->lock, flags);
-	for_each_clear_bit_from(i, &priv->pchans_used, max) {
+	for_each_clear_bit_from(i, priv->pchans_used, max) {
 		pchan = &pchans[i];
 		pchan->vchan = vchan;
 		set_bit(i, priv->pchans_used);
-- 
3.14159

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

linux-next: build failure after merge of the arm tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-04-21 00:50 +0200
  Re: linux-next: build failure after merge of the arm tree Mason <slash.tmp@free.fr> - 2017-04-21 10:00 +0200
    [PATCH] dmaengine: sun4i: fix invalid argument Mason <slash.tmp@free.fr> - 2017-04-21 10:10 +0200
      Re: [PATCH] dmaengine: sun4i: fix invalid argument Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-04-21 10:30 +0200
        [PATCH v2] dmaengine: sun4i: fix invalid argument Mason <slash.tmp@free.fr> - 2017-04-21 10:50 +0200
          Re: [PATCH v2] dmaengine: sun4i: fix invalid argument Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-04-21 17:30 +0200
    Re: linux-next: build failure after merge of the arm tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-04-21 10:20 +0200
      Re: linux-next: build failure after merge of the arm tree Mason <slash.tmp@free.fr> - 2017-04-21 10:40 +0200
      Re: linux-next: build failure after merge of the arm tree Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-04-22 01:50 +0200
        Re: linux-next: build failure after merge of the arm tree Mason <slash.tmp@free.fr> - 2017-04-22 10:50 +0200
          Re: linux-next: build failure after merge of the arm tree Vinod Koul <vinod.koul@intel.com> - 2017-04-24 06:20 +0200
    Re: linux-next: build failure after merge of the arm tree Mason <slash.tmp@free.fr> - 2017-04-21 13:30 +0200

csiph-web