Re: [PATCH 2/2] i2c: xgene-slimpro: Add ACPI support by using PCC mailbox

From	Wolfram Sang <wsa@the-dreams.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] i2c: xgene-slimpro: Add ACPI support by using PCC mailbox
Date	2017-04-21 08:40 +0200
Message-ID	<tyAox-2um-5@gated-at.bofh.it> (permalink)
References	<tq6dY-4Gs-19@gated-at.bofh.it> <tq6dY-4Gs-29@gated-at.bofh.it> <tyfk6-6tb-11@gated-at.bofh.it> <tyr1U-565-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

> > I think it doesn't make sense to print a dev_err and return ENODEV which
> > is treated by the driver core as a non-error. It means "not present, but
> > OK". You probably want other error codes here.
> 
> How about -EINVAL for these -ENODEV error codes? Do you have any suggestion?

-EINVAL will do, I would go for -ENOENT, probably. But it doesn't matter
much.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/2] i2c: xgene-slimpro: Add ACPI support by using PCC  mailbox Wolfram Sang <wsa@the-dreams.de> - 2017-04-20 10:10 +0200
  Re: [PATCH 2/2] i2c: xgene-slimpro: Add ACPI support by using PCC mailbox Hoan Tran <hotran@apm.com> - 2017-04-20 22:40 +0200
    Re: [PATCH 2/2] i2c: xgene-slimpro: Add ACPI support by using PCC  mailbox Wolfram Sang <wsa@the-dreams.de> - 2017-04-21 08:40 +0200

csiph-web