Re: [PATCH 1/2] usb: dwc2: Remove unnecessary debug prints

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] usb: dwc2: Remove unnecessary debug prints
Date	2017-04-20 00:00 +0200
Message-ID	<ty5NM-b4-15@gated-at.bofh.it> (permalink)
References	<txVOp-2NI-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 2017-04-19 at 15:16 +0400, Razmik Karapetyan wrote:
> Removed unnecessary debug prints about DMA mode for host side
> from dwc2_gahbcfg_init() function.

Why are these unnecessary?  Are these emitted elsewhere?

and...

> diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
[]
> @@ -302,22 +302,10 @@ static int dwc2_gahbcfg_init(struct dwc2_hsotg *hsotg)
[]
>  	if (hsotg->params.host_dma)
>  		ahbcfg |= GAHBCFG_DMA_EN;
> +	else
> +		hsotg->params.dma_desc_enable = false;

This change isn't mentioned in the commit message.
Why is is useful?

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] usb: dwc2: Remove unnecessary debug prints Razmik Karapetyan <Razmik.Karapetyan@synopsys.com> - 2017-04-19 13:20 +0200
  Re: [PATCH 1/2] usb: dwc2: Remove unnecessary debug prints Joe Perches <joe@perches.com> - 2017-04-20 00:00 +0200

csiph-web