Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1626764

Re: [PATCH v2 1/2] hp-wmi: Do not shadow error values

Show all headers | View raw

On Wed, Apr 19, 2017 at 07:41:53PM +0200, Carlo Caione wrote:
> From: Carlo Caione <carlo@endlessm.com>
> 
> All the helper functions (i.e. hp_wmi_dock_state, hp_wmi_tablet_state,
> ...) using hp_wmi_perform_query to perform an HP WMI query shadow the
> returned value in case of error.
> 
> We return -EINVAL only when the HP WMI query returns a positive value
> (the specific error code) to not mix this up with the actual value
> returned by the helper function.

So Andy is correct in that we try to avoid shadowing error codes where possible.
I accepted v1 of this series because it fixed an existing problem in a way
consistent with the existing code.

Since v1 is already in for-next, let's consider the following a subsequent
cleanup. Would you please create a new patch to address the shadowing error code
issues on top of the v1 patch series.

Thanks,
-- 
Darren Hart
VMware Open Source Technology Center

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/2] hp-wmi: Fix dock status and tablet mode reporting Carlo Caione <carlo@caione.org> - 2017-04-19 19:50 +0200
  [PATCH v2 1/2] hp-wmi: Do not shadow error values Carlo Caione <carlo@caione.org> - 2017-04-19 19:50 +0200
    Re: [PATCH v2 1/2] hp-wmi: Do not shadow error values Darren Hart <dvhart@infradead.org> - 2017-04-19 22:20 +0200
      Re: [PATCH v2 1/2] hp-wmi: Do not shadow error values Carlo Caione <carlo@endlessm.com> - 2017-04-19 22:30 +0200
  [PATCH v2 2/2] hp-wmi: Fix detection for dock and tablet mode Carlo Caione <carlo@caione.org> - 2017-04-19 19:50 +0200

csiph-web