Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1626790
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v1 1/2] gpio: gpio-wcove: fix GPIO irq status mask |
| Date | 2017-04-19 22:50 +0200 |
| Message-ID | <ty4I2-80K-19@gated-at.bofh.it> (permalink) |
| References | <twdmq-3Wz-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Apr 14, 2017 at 8:29 PM, <sathyanarayanan.kuppuswamy@linux.intel.com> wrote: > From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> > > According to Whiskey cove PMIC spec, bit 7 of GPIOIRQ0_REG belongs to cove -> Cove > battery IO. So we should skip this bit when checking for GPIO irq pending irq -> IRQ > status. Otherwise, wcove_gpio_irq_handler() might go into the infinite > loop until irq "pending" status becomes 0. This patch fixes this issue. Ditto. > +#define GPIO_IRQ0_MASK 0x7f > +#define GPIO_IRQ1_MASK 0x3f GENMASK() > - pending = p[0] | (p[1] << 8); > + pending = (p[0] & GPIO_IRQ0_MASK) | > + ((p[1] & GPIO_IRQ1_MASK) << 7); I would leave this on one line despite 80 characters limit (actually how long is it?). -- With Best Regards, Andy Shevchenko
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v1 1/2] gpio: gpio-wcove: fix GPIO irq status mask sathyanarayanan.kuppuswamy@linux.intel.com - 2017-04-14 19:40 +0200
[PATCH v1 2/2] gpio: gpio-wcove: fix irq pending status bit width sathyanarayanan.kuppuswamy@linux.intel.com - 2017-04-14 19:40 +0200
Re: [PATCH v1 2/2] gpio: gpio-wcove: fix irq pending status bit width Linus Walleij <linus.walleij@linaro.org> - 2017-04-24 15:20 +0200
Re: [PATCH v1 2/2] gpio: gpio-wcove: fix irq pending status bit width Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-04-24 16:30 +0200
Re: [PATCH v1 1/2] gpio: gpio-wcove: fix GPIO irq status mask Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-04-19 22:50 +0200
Re: [PATCH v1 1/2] gpio: gpio-wcove: fix GPIO irq status mask sathyanarayanan kuppuswamy <sathyanarayanan.kuppuswamy@linux.intel.com> - 2017-04-21 03:00 +0200
[PATCH v2 1/1] gpio: gpio-wcove: fix GPIO IRQ status mask sathyanarayanan.kuppuswamy@linux.intel.com - 2017-04-24 21:20 +0200
csiph-web