Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1626757

Re: [PATCH] blutooth: try to improve CONFIG_SERIAL_DEV_BUS dependency

Show all headers | View raw

Hi Arnd,

> With CONFIG_SERIAL_DEV_BUS=m, the hci_serdev.o file does not actually
> get built into hci_uart.o as the Makefile doesn't pick it up, leading
> to a link error with anything referring to it:
> 
> ERROR: "hci_uart_register_device" [drivers/bluetooth/hci_nokia.ko] undefined!
> scripts/Makefile.modpost:91: recipe for target '__modpost' failed
> 
> Changing this in the Makefile would cause another problem when
> hci_uart itself is built-in and cannot reference symbols from the
> serdev module.
> 
> This tries to address both problems by introducing a new hidden
> Kconfig symbol that controls both the compilation of hci_serdev.o
> and whether the Nokia driver can be selected. This seems to address
> the problem for me, though there might be a better way to do it.
> 
> Fixes: 7bb318680e86 ("Bluetooth: add nokia driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/bluetooth/Kconfig  | 8 +++++++-
> drivers/bluetooth/Makefile | 2 +-
> 2 files changed, 8 insertions(+), 2 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] blutooth: try to improve CONFIG_SERIAL_DEV_BUS dependency Arnd Bergmann <arnd@arndb.de> - 2017-04-19 20:00 +0200
  Re: [PATCH] blutooth: try to improve CONFIG_SERIAL_DEV_BUS dependency Marcel Holtmann <marcel@holtmann.org> - 2017-04-19 22:10 +0200
  Re: [PATCH] blutooth: try to improve CONFIG_SERIAL_DEV_BUS dependency Sebastian Reichel <sre@kernel.org> - 2017-04-20 02:20 +0200
    Re: [PATCH] blutooth: try to improve CONFIG_SERIAL_DEV_BUS dependency Marcel Holtmann <marcel@holtmann.org> - 2017-04-20 09:00 +0200
      Re: [PATCH] blutooth: try to improve CONFIG_SERIAL_DEV_BUS dependency Arnd Bergmann <arnd@arndb.de> - 2017-04-20 09:10 +0200

csiph-web