Re: [v5,3/8] mfd: retu: Add OF device ID table

From	Wolfram Sang <wsa@the-dreams.de>
Newsgroups	linux.kernel
Subject	Re: [v5,3/8] mfd: retu: Add OF device ID table
Date	2017-04-19 21:50 +0200
Message-ID	<ty3LX-7rV-11@gated-at.bofh.it> (permalink)
References	<tvufE-7kr-37@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Apr 12, 2017 at 02:27:54PM -0300, Javier Martinez Canillas wrote:
> The driver doesn't have a struct of_device_id table but supported devices
> are registered via Device Trees. This is working on the assumption that a
> I2C device registered via OF will always match a legacy I2C device ID and
> that the MODALIAS reported will always be of the form i2c:<device>.
> 
> But this could change in the future so the correct approach is to have a
> OF device ID table if the devices are registered via OF.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> Acked-by: Rob Herring <robh@kernel.org>
> Acked-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> Acked-by: Tony Lindgren <tony@atomide.com>
> Acked-by: Lee Jones <lee.jones@linaro.org>

Reviewed-by: Wolfram Sang <wsa@the-dreams.de>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v5 0/8] mfd: Add OF device table to I2C drivers that are missing it Javier Martinez Canillas <javier@osg.samsung.com> - 2017-04-12 19:30 +0200
  [PATCH v5 2/8] mfd: retu: Drop -mfd suffix from I2C device ID name Javier Martinez Canillas <javier@osg.samsung.com> - 2017-04-12 19:30 +0200
    Re: [v5,2/8] mfd: retu: Drop -mfd suffix from I2C device ID name Wolfram Sang <wsa@the-dreams.de> - 2017-04-19 21:50 +0200
  [PATCH v5 1/8] dt-bindings: mfd: Add retu/tahvo ASIC chips bindings Javier Martinez Canillas <javier@osg.samsung.com> - 2017-04-12 19:30 +0200
    Re: [v5,1/8] dt-bindings: mfd: Add retu/tahvo ASIC chips bindings Wolfram Sang <wsa@the-dreams.de> - 2017-04-19 21:40 +0200
  [PATCH v5 4/8] ARM: dts: n8x0: Add vendor prefix to retu node Javier Martinez Canillas <javier@osg.samsung.com> - 2017-04-12 19:30 +0200
    Re: [v5,4/8] ARM: dts: n8x0: Add vendor prefix to retu node Wolfram Sang <wsa@the-dreams.de> - 2017-04-19 21:50 +0200
  [PATCH v5 3/8] mfd: retu: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-04-12 19:30 +0200
    Re: [v5,3/8] mfd: retu: Add OF device ID table Wolfram Sang <wsa@the-dreams.de> - 2017-04-19 21:50 +0200

csiph-web