Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1626560

Re: [PATCH] net: phy: fix auto-negotiation stall due to unavailable interrupt

Show all headers | View raw

> 19 апр. 2017 г., в 19:32, Florian Fainelli <f.fainelli@gmail.com> написал(а):
> 
> http://patchwork.ozlabs.org/patch/743773/
> 
> Roger can you also test Alexander's patch?

If MAC use phy_start_aneg() instead of phy_start() my patch will not work as
expected. Roger, if patch don’t work for you please check what MAC bring up PHY using
phy_start():

http://patchwork.ozlabs.org/patch/752308/

Is it correct to start PHY inside MAC probe using phy_start_aneg()? Or phy_start() must be used?

And probably this tags should be added for my patch:
Fixes: 3c293f4e08b5 ("net: phy: Trigger state machine on state change and not polling.")
Cc: stable <stable@vger.kernel.org> # v4.9+

Because I bisected to commit 529ed1275263 ("net: phy: phy drivers
should not set SUPPORTED_[Asym_]Pause») that looks pretty good.

Also, there is another issue I found. link_timeout doesn’t work for interrupt driven PHY.
It is possible to implement timer to handle this case.
Florian, what do you think? Should this be fixed?

Alexander.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] net: phy: fix auto-negotiation stall due to unavailable interrupt Alexander Kochetkov <al.kochet@gmail.com> - 2017-04-19 15:50 +0200
  Re: [PATCH] net: phy: fix auto-negotiation stall due to unavailable interrupt Alexander Kochetkov <al.kochet@gmail.com> - 2017-04-19 16:10 +0200
    Re: [PATCH] net: phy: fix auto-negotiation stall due to unavailable  interrupt Florian Fainelli <f.fainelli@gmail.com> - 2017-04-19 18:40 +0200
      Re: [PATCH] net: phy: fix auto-negotiation stall due to unavailable interrupt Alexander Kochetkov <al.kochet@gmail.com> - 2017-04-19 19:00 +0200
        Re: [PATCH] net: phy: fix auto-negotiation stall due to unavailable  interrupt Roger Quadros <rogerq@ti.com> - 2017-04-20 11:30 +0200
  Re: [PATCH] net: phy: fix auto-negotiation stall due to unavailable  interrupt Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-04-19 20:20 +0200

csiph-web