Re: [PATCH 2/2] ACPI / scan: Avoid enumerating devices more than once

From	joeyli <jlee@suse.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] ACPI / scan: Avoid enumerating devices more than once
Date	2017-04-19 18:50 +0200
Message-ID	<ty0XM-5M7-17@gated-at.bofh.it> (permalink)
References	<tx1Md-1rQ-3@gated-at.bofh.it> <tx1Md-1rQ-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Apr 17, 2017 at 01:20:48AM +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> acpi_bus_attach() does not check the visited flag for devices that
> have been enumerated already and some of them may be enumerated
> for multiple times as a result, because some callers of
> acpi_bus_scan() don't check the visited flag either.
> 
> For this reason, modify acpi_bus_attach() to check the visited flag
> and avoid enumerating devices that have already been enumerated.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Reviewed-by: Joey Lee <jlee@suse.com>

Thanka a lot!
Joey Lee

> ---
>  drivers/acpi/scan.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> Index: linux-pm/drivers/acpi/scan.c
> ===================================================================
> --- linux-pm.orig/drivers/acpi/scan.c
> +++ linux-pm/drivers/acpi/scan.c
> @@ -1850,6 +1850,8 @@ static void acpi_bus_attach(struct acpi_
>  			device->flags.power_manageable = 0;
>  
>  		device->flags.initialized = true;
> +	} else if (device->flags.visited) {
> +		goto ok;
>  	}
>  
>  	ret = acpi_scan_attach_handler(device);
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] ACPI / scan: Avoid enumerating devices more than once "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-04-17 01:30 +0200
  Re: [PATCH 2/2] ACPI / scan: Avoid enumerating devices more than once Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-04-18 12:30 +0200
  Re: [PATCH 2/2] ACPI / scan: Avoid enumerating devices more than once joeyli <jlee@suse.com> - 2017-04-19 18:50 +0200

csiph-web