Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1626466

Re: [PATCH 1/2] hp-wmi: Fix error value for hp_wmi_tablet_state

Show all headers | View raw

On Wed, Apr 19, 2017 at 7:24 PM, Carlo Caione <carlo@endlessm.com> wrote:
> On Wed, Apr 19, 2017 at 6:21 PM, Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
>> On Sun, Apr 9, 2017 at 4:56 PM, Carlo Caione <carlo@caione.org> wrote:
>>> From: Carlo Caione <carlo@endlessm.com>
>>>
>>> hp_wmi_tablet_state() fails to return the correct error code when
>>> hp_wmi_perform_query() returns the HP WMI query specific error code
>>> that is a positive value.
>>
>>>         int ret = hp_wmi_perform_query(HPWMI_HARDWARE_QUERY, 0, &state,
>>>                                        sizeof(state), sizeof(state));
>>>         if (ret)
>>> -               return ret;
>>> +               return -EINVAL;
>>
>> Shouldn't be something like
>>
>> if (ret)
>>  return ret < 0 ? ret : -EINVAL;
>>
>> Looking into the code it looks like it may return all possible values:
>> 0, negative, positive.
>
> When the HP WMI query returns a positive value something went wrong.
> hp_wmi_perform_query() returns 0 on success.

Yes, that's what I didn't object anyhow. My point is not to shadow
negative errors if any.

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] hp-wmi: Fix error value for hp_wmi_tablet_state Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-04-19 18:30 +0200
  Re: [PATCH 1/2] hp-wmi: Fix error value for hp_wmi_tablet_state Carlo Caione <carlo@endlessm.com> - 2017-04-19 18:30 +0200
    Re: [PATCH 1/2] hp-wmi: Fix error value for hp_wmi_tablet_state Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-04-19 18:30 +0200

csiph-web