Re: [PATCH v6 17/39] platform: add video-multiplexer subdevice driver

From	Pavel Machek <pavel@ucw.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6 17/39] platform: add video-multiplexer subdevice driver
Date	2017-04-18 11:10 +0200
Message-ID	<txxj4-4lo-11@gated-at.bofh.it> (permalink)
References	(1 earlier) <tpNuG-7Yq-5@gated-at.bofh.it> <tsw4h-4Ve-1@gated-at.bofh.it> <tvNrX-3KR-9@gated-at.bofh.it> <twgaB-5Ia-5@gated-at.bofh.it> <txwwG-3Q5-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi!

> That self-referencing mux-controls property looks a bit superfluous:
> 
> 	mux: video-multiplexer {
> 		mux-controls = <&mux>;
> 	};
> 
> Other than that, I'm completely fine with splitting the compatible into
> something like video-mux-gpio and video-mux-mmio and reusing the
> mux-gpios property for video-mux-gpio.

Agreed, I overseen that.

> > You should be able to use code in drivers/mux as a library...
> 
> This is a good idea in principle, but this requires some rework of the
> mux subsystem, and that subsystem hasn't even landed yet. For now I'd
> like to focus on getting the DT bindings right.
> 
> I'd honestly prefer to not add this rework as a requirement for the i.MX
> media drivers to get into staging.

Hmm. staging/ normally accepts code with bigger design problems than
that.

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v6 17/39] platform: add video-multiplexer subdevice  driver Philipp Zabel <p.zabel@pengutronix.de> - 2017-04-13 16:00 +0200
  Re: [PATCH v6 17/39] platform: add video-multiplexer subdevice driver Pavel Machek <pavel@ucw.cz> - 2017-04-14 22:40 +0200
    Re: [PATCH v6 17/39] platform: add video-multiplexer subdevice  driver Philipp Zabel <p.zabel@pengutronix.de> - 2017-04-18 10:20 +0200
      Re: [PATCH v6 17/39] platform: add video-multiplexer subdevice driver Pavel Machek <pavel@ucw.cz> - 2017-04-18 11:10 +0200

csiph-web