Re: [PATCH 2/3] ARM: sun8i: a83t: Drop leading zeroes from device node addresses

From	Chen-Yu Tsai <wens@csie.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/3] ARM: sun8i: a83t: Drop leading zeroes from device node addresses
Date	2017-04-18 11:30 +0200
Message-ID	<txxCq-4sb-19@gated-at.bofh.it> (permalink)
References	<txwdj-3uy-3@gated-at.bofh.it> <txwdj-3uy-1@gated-at.bofh.it> <txxj4-4lo-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Apr 18, 2017 at 5:03 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> On Tue, Apr 18, 2017 at 12:22:04PM +0800, Chen-Yu Tsai wrote:
>> Kbuild now complains about leading zeroes in the address portion of
>> device node names.
>>
>> Get rid of them.
>>
>> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
>> ---
>>  arch/arm/boot/dts/sun8i-a83t.dtsi | 10 +++++-----
>>  1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi
>> index 913aacafe8d5..82cb87f21b96 100644
>> --- a/arch/arm/boot/dts/sun8i-a83t.dtsi
>> +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi
>> @@ -162,7 +162,7 @@
>>               #size-cells = <1>;
>>               ranges;
>>
>> -             pio: pinctrl@01c20800 {
>> +             pio: pinctrl@1c20800 {
>
> As far as I know this breaks Uboot's auto-addition of stdout-path

You're right. It breaks as Uboot has the path to the uarts hard-coded.
That sucks. And from what I can tell, it's not easily solvable by just
switching to serial alias based references. CONS_INDEX won't line up
on the A23/A33 Q8 tablets.

Maybe we can just keep the uart device node the same for now, but fix
all the other ones. We can come back and fix the uart later once we
figure out how to fix Uboot.

Regards
ChenYu

Thread

[PATCH 2/3] ARM: sun8i: a83t: Drop leading zeroes from device node addresses Chen-Yu Tsai <wens@csie.org> - 2017-04-18 10:00 +0200
  Re: [PATCH 2/3] ARM: sun8i: a83t: Drop leading zeroes from device  node addresses Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-04-18 11:10 +0200
    Re: [PATCH 2/3] ARM: sun8i: a83t: Drop leading zeroes from device  node addresses Chen-Yu Tsai <wens@csie.org> - 2017-04-18 11:30 +0200
      Re: [PATCH 2/3] ARM: sun8i: a83t: Drop leading zeroes from device  node addresses Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-04-19 09:00 +0200

csiph-web