Re: [PATCH] x86, kvm: Handle PFNs outside of kernel reach when touching GPTEs

From	Paolo Bonzini <pbonzini@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] x86, kvm: Handle PFNs outside of kernel reach when touching GPTEs
Date	2017-04-18 10:20 +0200
Message-ID	<txwwG-3Q5-5@gated-at.bofh.it> (permalink)
References	<tsT0S-364-19@gated-at.bofh.it> <ttgAa-1jL-19@gated-at.bofh.it> <tvqlI-4Uw-23@gated-at.bofh.it> <txd0Z-8uH-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 17/04/2017 13:26, Xiao Guangrong wrote:
>>
> 
> Sounds reasonable, however it is incomplete so far as there are some
> code paths still do not support non-page backend memory, e.g,
> emulator_cmpxchg_emulated().
> 
> I would suggest to unify the code introduced in this patch with existing
> hva_to_pfn(), also we can introduce a common API, maybe named
> kvm_map_hva(), to improve the caller sides.

I agree with Guangrong's suggestion.

Paolo

> BTW, i do not know why we used kmap_atomic() rather than kmap(), the
> path of cmpxchg_gpte() is sleep-able anyway.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] x86, kvm: Handle PFNs outside of kernel reach when  touching GPTEs "Sironi, Filippo" <sironi@amazon.de> - 2017-04-12 15:20 +0200
  Re: [PATCH] x86, kvm: Handle PFNs outside of kernel reach when  touching GPTEs Xiao Guangrong <guangrong.xiao@gmail.com> - 2017-04-17 13:30 +0200
    Re: [PATCH] x86, kvm: Handle PFNs outside of kernel reach when  touching GPTEs Paolo Bonzini <pbonzini@redhat.com> - 2017-04-18 10:20 +0200

csiph-web