Re: [PATCH v2 3/3] arm64: dts: exynos: Add support for s6e3hf2 panel device on TM2e board

From	Hoegeun Kwon <hoegeun.kwon@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 3/3] arm64: dts: exynos: Add support for s6e3hf2 panel device on TM2e board
Date	2017-04-18 09:50 +0200
Message-ID	<txw3E-3rt-5@gated-at.bofh.it> (permalink)
References	<tx81k-5DY-21@gated-at.bofh.it> <tx81l-5DY-45@gated-at.bofh.it> <tx81l-5DY-43@gated-at.bofh.it> <txuuS-2Go-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 04/18/2017 03:00 PM, Andrzej Hajda wrote:
> On 17.04.2017 08:02, Hoegeun Kwon wrote:
>> This patch add the panel device tree node for s6e3hf2 display
>> controller to TM2e dts.
>>
>> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
> Maybe it would be good to remove te-gpios property - tm2/tm2e uses
> hardware trigger, so it is not necessary and generates useless interrupts.

Thanks for your review.

I agree, but I thinks remove the te-gpio property after your patch [1] 
has been merged.


[1] https://patchwork.kernel.org/patch/9625383/

Best regards,
Hoegeun

>
> Beside this:
> Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
>   --
> Regards
> Andrzej
>> ---
>>   arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts | 12 ++++++++++++
>>   1 file changed, 12 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts
>> index 694717a..98ad094 100644
>> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts
>> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts
>> @@ -52,6 +52,18 @@
>>   	assigned-clock-rates = <278000000>, <400000000>;
>>   };
>>   
>> +&dsi {
>> +	panel@0 {
>> +		compatible = "samsung,s6e3hf2";
>> +		reg = <0>;
>> +		vdd3-supply = <&ldo27_reg>;
>> +		vci-supply = <&ldo28_reg>;
>> +		reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>;
>> +		enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>;
>> +		te-gpios = <&gpf1 3 GPIO_ACTIVE_HIGH>;
>> +	};
>> +};
>> +
>>   &ldo31_reg {
>>   	regulator-name = "TSP_VDD_1.8V_AP";
>>   	regulator-min-microvolt = <1800000>;
>
>
>

Thread

[PATCH v2 0/3] Add support for the S6E3HF2 panel on TM2e board Hoegeun Kwon <hoegeun.kwon@samsung.com> - 2017-04-17 08:10 +0200
  [PATCH v2 2/3] drm/panel: s6e3ha2: Add support for s6e3hf2 panel on  TM2e board Hoegeun Kwon <hoegeun.kwon@samsung.com> - 2017-04-17 08:10 +0200
    Re: [PATCH v2 2/3] drm/panel: s6e3ha2: Add support for s6e3hf2 panel  on TM2e board Andrzej Hajda <a.hajda@samsung.com> - 2017-04-18 08:00 +0200
      Re: [PATCH v2 2/3] drm/panel: s6e3ha2: Add support for s6e3hf2 panel  on TM2e board Inki Dae <inki.dae@samsung.com> - 2017-04-18 10:10 +0200
  [PATCH v2 3/3] arm64: dts: exynos: Add support for s6e3hf2 panel  device on TM2e board Hoegeun Kwon <hoegeun.kwon@samsung.com> - 2017-04-17 08:10 +0200
    Re: [PATCH v2 3/3] arm64: dts: exynos: Add support for s6e3hf2 panel  device on TM2e board Andrzej Hajda <a.hajda@samsung.com> - 2017-04-18 08:10 +0200
      Re: [PATCH v2 3/3] arm64: dts: exynos: Add support for s6e3hf2 panel  device on TM2e board Hoegeun Kwon <hoegeun.kwon@samsung.com> - 2017-04-18 09:50 +0200
        Re: [PATCH v2 3/3] arm64: dts: exynos: Add support for s6e3hf2 panel  device on TM2e board Andrzej Hajda <a.hajda@samsung.com> - 2017-04-18 10:00 +0200
          Re: [PATCH v2 3/3] arm64: dts: exynos: Add support for s6e3hf2  panel device on TM2e board Hoegeun Kwon <hoegeun.kwon@samsung.com> - 2017-04-18 10:30 +0200

csiph-web