[PATCH] net/mlx4: suppress 'may be used uninitialized' warning

From	Greg Thelen <gthelen@google.com>
Newsgroups	linux.kernel
Subject	[PATCH] net/mlx4: suppress 'may be used uninitialized' warning
Date	2017-04-18 08:30 +0200
Message-ID	<txuOd-2MU-5@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

gcc 4.8.4 complains that mlx4_SW2HW_MPT_wrapper() uses an uninitialized
'mpt' variable:
  drivers/net/ethernet/mellanox/mlx4/resource_tracker.c: In function 'mlx4_SW2HW_MPT_wrapper':
  drivers/net/ethernet/mellanox/mlx4/resource_tracker.c:2802:12: warning: 'mpt' may be used uninitialized in this function [-Wmaybe-uninitialized]
     mpt->mtt = mtt;

I think this warning is a false complaint.  mpt is only used when
mr_res_start_move_to() return zero, and in all such cases it initializes
mpt.  But apparently gcc cannot see that.

Initialize mpt to avoid the warning.

Signed-off-by: Greg Thelen <gthelen@google.com>
---
 drivers/net/ethernet/mellanox/mlx4/resource_tracker.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c b/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c
index d8d5d161b8c7..4aa29ee93013 100644
--- a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c
+++ b/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c
@@ -2749,7 +2749,7 @@ int mlx4_SW2HW_MPT_wrapper(struct mlx4_dev *dev, int slave,
 	int err;
 	int index = vhcr->in_modifier;
 	struct res_mtt *mtt;
-	struct res_mpt *mpt;
+	struct res_mpt *mpt = NULL;
 	int mtt_base = mr_get_mtt_addr(inbox->buf) / dev->caps.mtt_entry_sz;
 	int phys;
 	int id;
-- 
2.12.2.762.g0e3151a226-goog

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] net/mlx4: suppress 'may be used uninitialized' warning Greg Thelen <gthelen@google.com> - 2017-04-18 08:30 +0200
  Re: [PATCH] net/mlx4: suppress 'may be used uninitialized' warning Leon Romanovsky <leon@kernel.org> - 2017-04-18 09:10 +0200
    Re: [PATCH] net/mlx4: suppress 'may be used uninitialized' warning Greg Thelen <gthelen@google.com> - 2017-04-18 09:30 +0200
  Re: [PATCH] net/mlx4: suppress 'may be used uninitialized' warning David Miller <davem@davemloft.net> - 2017-04-20 19:30 +0200

csiph-web