Re: [PATCH] usb: Make sure usb/phy/of gets built-in

From	Frank Rowand <frowand.list@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] usb: Make sure usb/phy/of gets built-in
Date	2017-04-18 05:20 +0200
Message-ID	<txrQl-Wj-5@gated-at.bofh.it> (permalink)
References	<tvMcx-30k-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 04/13/17 05:33, Alexey Brodkin wrote:
> DWC3 driver uses of_usb_get_phy_mode() which is
> implemented in drivers/usb/phy/of.c and in bare minimal
> configuration it might not be pulled in kernel binary.
> 
> In case of ARC or ARM this could be easily reproduced with
> "allnodefconfig" +CONFIG_USB=m +CONFIG_USB_DWC3=m.
> 
> On building all ends-up with:
> ---------------------->8------------------
>   Kernel: arch/arm/boot/Image is ready
>   Kernel: arch/arm/boot/zImage is ready
>   Building modules, stage 2.
>   MODPOST 5 modules
> ERROR: "of_usb_get_phy_mode" [drivers/usb/dwc3/dwc3.ko] undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2
> ---------------------->8------------------
> 
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Nicolas Pitre <nicolas.pitre@linaro.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Felipe Balbi <balbi@kernel.org>
> Cc: Felix Fietkau <nbd@nbd.name>
> Cc: Jeremy Kerr <jk@ozlabs.org>
> Cc: linux-snps-arc@lists.infradead.org
> Cc: stable@vger.kernel.org
> ---
>  drivers/Makefile | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/Makefile b/drivers/Makefile
> index 2eced9afba53..8f8bdc9e3d29 100644
> --- a/drivers/Makefile
> +++ b/drivers/Makefile
> @@ -104,6 +104,7 @@ obj-$(CONFIG_USB_PHY)		+= usb/
>  obj-$(CONFIG_USB)		+= usb/
>  obj-$(CONFIG_PCI)		+= usb/
>  obj-$(CONFIG_USB_GADGET)	+= usb/

> +obj-$(CONFIG_OF)		+= usb/

Would CONFIG_USB_SUPPORT make more sense? (And does it work?)


>  obj-$(CONFIG_SERIO)		+= input/serio/
>  obj-$(CONFIG_GAMEPORT)		+= input/gameport/
>  obj-$(CONFIG_INPUT)		+= input/
>

Thread

[PATCH] usb: Make sure usb/phy/of gets built-in Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2017-04-13 14:40 +0200
  Re: [PATCH] usb: Make sure usb/phy/of gets built-in Frank Rowand <frowand.list@gmail.com> - 2017-04-18 05:20 +0200
    Re: [PATCH] usb: Make sure usb/phy/of gets built-in Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2017-04-18 14:30 +0200
      Re: [PATCH] usb: Make sure usb/phy/of gets built-in Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2017-04-24 14:50 +0200

csiph-web