[PATCH] of: fix "/cpus" reference leak in of_numa_parse_cpu_nodes()

From	Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	[PATCH] of: fix "/cpus" reference leak in of_numa_parse_cpu_nodes()
Date	2017-04-18 02:30 +0200
Message-ID	<txpbP-7Bo-1@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

The call to of_find_node_by_path("/cpus") returns the cpus device_node
with its reference count incremented. There is no matching of_node_put()
call in of_numa_parse_cpu_nodes() which results in a leaked reference
to the "/cpus" node.

This patch adds an of_node_put() to release the reference.

fixes: 298535c00a2c ("of, numa: Add NUMA of binding implementation.")
Signed-off-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
---
 drivers/of/of_numa.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/of/of_numa.c b/drivers/of/of_numa.c
index a53982a..2db1f7a 100644
--- a/drivers/of/of_numa.c
+++ b/drivers/of/of_numa.c
@@ -57,6 +57,8 @@ static void __init of_numa_parse_cpu_nodes(void)
 		else
 			node_set(nid, numa_nodes_parsed);
 	}
+
+	of_node_put(cpus);
 }
 
 static int __init of_numa_parse_memory_nodes(void)
-- 
1.8.3.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] of: fix "/cpus" reference leak in of_numa_parse_cpu_nodes() Tyrel Datwyler <tyreld@linux.vnet.ibm.com> - 2017-04-18 02:30 +0200
  Re: [PATCH] of: fix "/cpus" reference leak in of_numa_parse_cpu_nodes() Rob Herring <robh+dt@kernel.org> - 2017-04-18 18:10 +0200

csiph-web