Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1624962

[PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning

Show all headers | View raw

Swap string in the dev_warn() call with __func__ argument, instead of
explicitly calling the function name in the string:

        WARNING: Prefer using "%s", __func__ to embedded function names
        #417: FILE: main_usb.c:417:
        +                        "usb_device_reset fail status=%d\n", status);

        total: 0 errors, 1 warnings, 1058 lines checked

And after fix:

        main_usb.c has no obvious style problems and is ready for submission.

Signed-off-by: Chewie Lin <linsh@oregonstate.edu>
---
 drivers/staging/vt6656/main_usb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c
index 9e074e9daf4e..71c4511b4cff 100644
--- a/drivers/staging/vt6656/main_usb.c
+++ b/drivers/staging/vt6656/main_usb.c
@@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv)
 	status = usb_reset_device(priv->usb);
 	if (status)
 		dev_warn(&priv->usb->dev,
-			 "usb_device_reset fail status=%d\n", status);
+			 "%s fail status=%d\n", __func__, status);
 }
 
 static void vnt_free_int_bufs(struct vnt_private *priv)
-- 
2.12.2

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/1] drivers/staging/vt6656/main_usb.c: checkpatch warning Chewie Lin <linsh@oregonstate.edu> - 2017-04-18 02:00 +0200
  [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning Chewie Lin <linsh@oregonstate.edu> - 2017-04-18 02:00 +0200
    Re: [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning Greg KH <greg@kroah.com> - 2017-04-18 06:20 +0200
      Re: [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning Chewie Lin <linsh@oregonstate.edu> - 2017-04-18 06:50 +0200

csiph-web