Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1624873

[PATCH] hidma_mgmt_sys: Use devm_kmalloc_array() in hidma_mgmt_init_sys()

Show all headers | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 17 Apr 2017 22:42:40 +0200

* A multiplication for the size determination of a memory allocation
  indicated that an array data structure should be processed.
  Thus use the corresponding function "devm_kmalloc_array".

  This issue was detected by using the Coccinelle software.

* Delete the local variable "required" which became unnecessary
  with this refactoring.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/dma/qcom/hidma_mgmt_sys.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/dma/qcom/hidma_mgmt_sys.c b/drivers/dma/qcom/hidma_mgmt_sys.c
index d61f1068a34b..e7222a0e9ba4 100644
--- a/drivers/dma/qcom/hidma_mgmt_sys.c
+++ b/drivers/dma/qcom/hidma_mgmt_sys.c
@@ -245,11 +245,12 @@ int hidma_mgmt_init_sys(struct hidma_mgmt_dev *mdev)
 {
 	unsigned int i;
 	int rc;
-	int required;
 	struct kobject *chanops;
 
-	required = sizeof(*mdev->chroots) * mdev->dma_channels;
-	mdev->chroots = devm_kmalloc(&mdev->pdev->dev, required, GFP_KERNEL);
+	mdev->chroots = devm_kmalloc_array(&mdev->pdev->dev,
+					   mdev->dma_channels,
+					   sizeof(*mdev->chroots),
+					   GFP_KERNEL);
 	if (!mdev->chroots)
 		return -ENOMEM;
 
-- 
2.12.2

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] hidma_mgmt_sys: Use devm_kmalloc_array() in  hidma_mgmt_init_sys() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 23:00 +0200
  Re: [PATCH] hidma_mgmt_sys: Use devm_kmalloc_array() in  hidma_mgmt_init_sys() Sinan Kaya <okaya@codeaurora.org> - 2017-04-18 00:30 +0200

csiph-web