Re: [PATCH] backlight: pwm_bl: Fix condition to set enable gpio as output

From	Geert Uytterhoeven <geert@linux-m68k.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] backlight: pwm_bl: Fix condition to set enable gpio as output
Date	2017-04-17 21:40 +0200
Message-ID	<txkFb-4Gv-21@gated-at.bofh.it> (permalink)
References	<twPUJ-2A3-1@gated-at.bofh.it> <twZr3-8it-9@gated-at.bofh.it> <txgUW-2mc-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Paul,

On Mon, Apr 17, 2017 at 5:38 PM, Paul Kocialkowski <contact@paulk.fr> wrote:
> Le dimanche 16 avril 2017 à 22:55 +0200, Geert Uytterhoeven a écrit :
>> On Sun, Apr 16, 2017 at 12:35 PM, Paul Kocialkowski <contact@paulk.fr> wrote:
>> > The move to a dedicated pwm_backlight_initial_power_state function in
>> > commit 7613c922315e308a6486d802abed2eb74443dffd modified the condition
>> > to set the enable gpio as output. This breaks specific use cases using
>> > that GPIO, such as tegra124-based nyan Chromebooks where backlight
>> > stopped working.
>> >
>> > This puts the condition back to the way it was before the move.
>> >
>> > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
>>
>> Does "[PATCH v2] backlight: pwm_bl: Fix GPIO out for unimplemented
>> .get_direction()"
>> (https://lkml.org/lkml/2017/4/4/225) fix your issue?
>
> This definitely solves the issue!
>
> Since this fixes broken backlight (that, in turn, makes systems unusable),
> perhaps this should be included in the next rc cycle?

You mean v4.11 final, as there probably won't be another rc?
Yes!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Thread

[PATCH] backlight: pwm_bl: Fix condition to set enable gpio as output Paul Kocialkowski <contact@paulk.fr> - 2017-04-16 12:50 +0200
  Re: [PATCH] backlight: pwm_bl: Fix condition to set enable gpio as output Geert Uytterhoeven <geert@linux-m68k.org> - 2017-04-16 23:00 +0200
    Re: [PATCH] backlight: pwm_bl: Fix condition to set enable gpio as  output Paul Kocialkowski <contact@paulk.fr> - 2017-04-17 17:40 +0200
      Re: [PATCH] backlight: pwm_bl: Fix condition to set enable gpio as output Geert Uytterhoeven <geert@linux-m68k.org> - 2017-04-17 21:40 +0200
        Re: [PATCH] backlight: pwm_bl: Fix condition to set enable gpio as  output Paul Kocialkowski <contact@paulk.fr> - 2017-04-18 11:00 +0200
          Re: [PATCH] backlight: pwm_bl: Fix condition to set enable gpio as  output Daniel Thompson <daniel.thompson@linaro.org> - 2017-04-20 12:00 +0200
            Re: [PATCH] backlight: pwm_bl: Fix condition to set enable gpio as output Geert Uytterhoeven <geert@linux-m68k.org> - 2017-04-20 12:20 +0200
            Re: [PATCH] backlight: pwm_bl: Fix condition to set enable gpio as  output Paul Kocialkowski <contact@paulk.fr> - 2017-04-22 15:10 +0200

csiph-web