[patch 01/10] timer: Invoke timer_start_debug() where it makes sense

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	[patch 01/10] timer: Invoke timer_start_debug() where it makes sense
Date	2017-04-17 21:00 +0200
Message-ID	<txk2t-4d7-1@gated-at.bofh.it> (permalink)
References	<txk2t-4d7-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

The timer start debug function is called before the proper timer base
is set.

As a consequence the trace data contains the stale CPU and flags values.

Call the debug function after setting the new base and flags.

Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 kernel/time/timer.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/kernel/time/timer.c
+++ b/kernel/time/timer.c
@@ -970,8 +970,6 @@ static inline int
 	if (!ret && pending_only)
 		goto out_unlock;
 
-	debug_activate(timer, expires);
-
 	new_base = get_target_base(base, timer->flags);
 
 	if (base != new_base) {
@@ -994,6 +992,8 @@ static inline int
 		}
 	}
 
+	debug_activate(timer, expires);
+
 	/* Try to forward a stale timer base clock */
 	forward_timer_base(base);

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[patch 01/10] timer: Invoke timer_start_debug() where it makes sense Thomas Gleixner <tglx@linutronix.de> - 2017-04-17 21:00 +0200

csiph-web