Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1624741

Re: [PATCH resend 3/4] uapi glibc compat: Do not check for __USE_MISC

Show all headers | View raw

From: Hauke Mehrtens <hauke@hauke-m.de>
Date: Wed, 12 Apr 2017 22:31:02 +0200

> __USE_MISC is glibc specific and not available in musl libc. Only do
> this check when glibc is used. This fixes a problem with musl libc.
> 
> Acked-by: Mikko Rapeli <mikko.rapeli@iki.fi>
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>

You yourself introduce this problem in patch #1.

The code before patch #1 was perfectly fine, as this code block only
existing in an area protected by __GLIBC__.

So you have to redo these patches such that you deal with all of
the fallout from changing __GLIBC__ into !__KERNEL__ at the same
time that you make that change.

Thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH resend 3/4] uapi glibc compat: Do not check for __USE_MISC Hauke Mehrtens <hauke@hauke-m.de> - 2017-04-12 22:40 +0200
  Re: [PATCH resend 3/4] uapi glibc compat: Do not check for  __USE_MISC David Miller <davem@davemloft.net> - 2017-04-17 19:00 +0200

csiph-web