Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1624694
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 05/25] net: mvpp2: Use kmalloc_array() in mvpp2_txq_init() |
| Date | 2017-04-17 17:20 +0200 |
| Message-ID | <txgBA-2f8-17@gated-at.bofh.it> (permalink) |
| References | <txgrT-2bp-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 17 Apr 2017 08:09:07 +0200
* A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus use the corresponding function "kmalloc_array".
This issue was detected by using the Coccinelle software.
* Replace the specification of a data structure by a pointer dereference
to make the corresponding size determination a bit safer according to
the Linux coding style convention.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/net/ethernet/marvell/mvpp2.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/marvell/mvpp2.c b/drivers/net/ethernet/marvell/mvpp2.c
index af5bfa13d976..a86d9111c476 100644
--- a/drivers/net/ethernet/marvell/mvpp2.c
+++ b/drivers/net/ethernet/marvell/mvpp2.c
@@ -5083,9 +5083,9 @@ static int mvpp2_txq_init(struct mvpp2_port *port,
for_each_present_cpu(cpu) {
txq_pcpu = per_cpu_ptr(txq->pcpu, cpu);
txq_pcpu->size = txq->size;
- txq_pcpu->buffs = kmalloc(txq_pcpu->size *
- sizeof(struct mvpp2_txq_pcpu_buf),
- GFP_KERNEL);
+ txq_pcpu->buffs = kmalloc_array(txq_pcpu->size,
+ sizeof(*txq_pcpu->buffs),
+ GFP_KERNEL);
if (!txq_pcpu->buffs)
goto error;
--
2.12.2
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 00/25] Ethernet-Marvell: Fine-tuning for several function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:10 +0200 [PATCH 02/25] net: mvneta: Improve two size determinations in mvneta_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:20 +0200 [PATCH 03/25] net: mvneta: Use kmalloc_array() in mvneta_txq_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:20 +0200 [PATCH 08/25] net: mvpp2: Improve another size determination in mvpp2_port_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:20 +0200 [PATCH 05/25] net: mvpp2: Use kmalloc_array() in mvpp2_txq_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:20 +0200 [PATCH 04/25] net: mvneta: Adjust six checks for null pointers SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:20 +0200 [PATCH 06/25] net: mvpp2: Improve two size determinations in mvpp2_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:20 +0200 [PATCH 07/25] net: mvpp2: Improve another size determination in mvpp2_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:20 +0200 [PATCH 09/25] net: mvpp2: Improve another size determination in mvpp2_bm_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:20 +0200 [PATCH 19/25] net: mvpp2: Rename a jump label in mvpp2_prs_vlan_add() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:30 +0200 [PATCH 17/25] net: mvpp2: Rename a jump label in mvpp2_txq_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:30 +0200 [PATCH 12/25] net: mvpp2: Improve a size determination in two functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:30 +0200 [PATCH 18/25] net: mvpp2: Rename a jump label in mvpp2_prs_double_vlan_add() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:30 +0200 [PATCH 11/25] net: mvpp2: Improve 27 size determinations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:30 +0200 [PATCH 10/25] net: mvpp2: Improve another size determination in mvpp2_prs_default_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:30 +0200 [PATCH 13/25] net: mvpp2: Fix a jump label position in mvpp2_rx() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:30 +0200 [PATCH 14/25] net: mvpp2: Rename a jump label in two functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:30 +0200 [PATCH 15/25] net: mvpp2: Adjust three error messages SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:30 +0200 [PATCH 16/25] net: mvpp2: Rename a jump label in mvpp2_tx_frag_process() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:30 +0200 [PATCH 22/25] net: pxa168_eth: Adjust four checks for null pointers SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:40 +0200 [PATCH 21/25] net: pxa168_eth: Use kcalloc() in two functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:40 +0200 [PATCH 24/25] skge: Adjust a null pointer check in skge_down() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:40 +0200 [PATCH 20/25] net: mvpp2: Adjust a null pointer check in mvpp2_egress_enable() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:40 +0200 [PATCH 23/25] skge: Use seq_puts() in skge_debug_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:40 +0200 [PATCH 25/25] sky2: Use seq_puts() in sky2_debug_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:40 +0200 Re: [PATCH 00/25] Ethernet-Marvell: Fine-tuning for several function implementations David Miller <davem@davemloft.net> - 2017-04-18 20:10 +0200
csiph-web