Re: [PATCH v1]] lib/btree.c: optimise the code by previously getpos function

From	Leno Hou <lenohou@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v1]] lib/btree.c: optimise the code by previously getpos function
Date	2017-04-19 16:50 +0200
Message-ID	<txZ5F-4CC-31@gated-at.bofh.it> (permalink)
References	<tuXWp-3vY-1@gated-at.bofh.it> <tv6Q3-Us-27@gated-at.bofh.it> <tvupk-7nO-9@gated-at.bofh.it> <tvupk-7nO-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> On 13 Apr 2017, at 1:32 AM, Christoph Hellwig <hch@infradead.org> wrote:
> 
> On Wed, Apr 12, 2017 at 06:03:10PM +0800, Leno Hou wrote:
>> 1. Actually, this is cleanup of the code to human being read but not
>> optimize. And When I compiled the kernel
>>    and checked with object code . It proved as same as before. So it's no
>> need to test this change.
>> 
>> 2. This Simple B+ Tree in Memory was used by SCSI driver QLA2XXX. so it
>> would be better to merge this
>>   cleanup for future optimize. Thanks.
> 
> If you care about the btree code a good first step would be to write a
> test suite instead of micro-optimizing it out of the blue without
> actually being able to test it.

OK. Thanks Christoph, I’m the newbie of kernel developer and will take more
time to search how to write test suite to prove that was optimized.

-Leno Hou

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v1]] lib/btree.c: optimise the code by previously getpos function Leno Hou <lenohou@gmail.com> - 2017-04-11 09:00 +0200
  Re: [PATCH v1]] lib/btree.c: optimise the code by previously getpos  function Christoph Hellwig <hch@infradead.org> - 2017-04-11 18:30 +0200
    Re: [PATCH v1]] lib/btree.c: optimise the code by previously getpos  function Christoph Hellwig <hch@infradead.org> - 2017-04-12 19:40 +0200
      Re: [PATCH v1]] lib/btree.c: optimise the code by previously getpos  function Leno Hou <lenohou@gmail.com> - 2017-04-19 16:50 +0200

csiph-web