Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1626041

Re: [RFC 1/2] dt-bindings: add mmio-based syscon mux controller DT bindings

Show all headers | View raw

On Thu, 2017-04-13 at 18:03 -0700, Steve Longerbeam wrote:
> 
> On 04/13/2017 08:48 AM, Philipp Zabel wrote:
> > This adds device tree binding documentation for mmio-based syscon
> > multiplexers controlled by a single bitfield in a syscon register
> > range.
> 
> Nice! (you beat me to it, I was about to embark on this myself :)
> 
> Looks good to me, just some minor comments below.
> 
[...]
> > +Define a syscon bitfield to be used to control a multiplexer. The parent
> I think "Define a register bitfield to be used ..." is more clear.
[...]
> > +- compatible : "gpio-mux"
> Er, "mmio-mux"

I'll change those, thanks.

[...]
> > +Example:
> > +
> > +	syscon {
> > +		compatible = "syscon";
> > +
> > +		mux: mux-controller@3 {
> > +			compatible = "mmio-mux";
> > +			reg = <0x3>;
> > +			bit-mask = <0x1>;
> > +			bit-shift = <5>;
> > +			#mux-control-cells = <0>;
> > +		};
> > +	};
> > +
> > +	video-mux {
> 
> I like this as an example consumer of a mmio-mux, but just
> the same some might argue this doesn't really fit here.

I don't think this is a problem, of course assuming that this video-mux
binding will actually come into existence.

regards
Philipp

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC 1/2] dt-bindings: add mmio-based syscon mux controller DT bindings Philipp Zabel <p.zabel@pengutronix.de> - 2017-04-13 17:50 +0200
  Re: [RFC 1/2] dt-bindings: add mmio-based syscon mux controller DT  bindings Steve Longerbeam <slongerbeam@gmail.com> - 2017-04-14 03:10 +0200
    Re: [RFC 1/2] dt-bindings: add mmio-based syscon mux controller DT  bindings Philipp Zabel <p.zabel@pengutronix.de> - 2017-04-19 13:50 +0200
  Re: [RFC 1/2] dt-bindings: add mmio-based syscon mux controller DT  bindings Philipp Zabel <p.zabel@pengutronix.de> - 2017-04-18 10:20 +0200
    Re: [RFC 1/2] dt-bindings: add mmio-based syscon mux controller DT  bindings Sakari Ailus <sakari.ailus@iki.fi> - 2017-04-18 12:10 +0200
      Re: [RFC 1/2] dt-bindings: add mmio-based syscon mux controller DT  bindings Pavel Machek <pavel@ucw.cz> - 2017-04-18 12:40 +0200
        Re: [RFC 1/2] dt-bindings: add mmio-based syscon mux controller DT  bindings Sakari Ailus <sakari.ailus@iki.fi> - 2017-04-18 13:00 +0200
          Re: [RFC 1/2] dt-bindings: add mmio-based syscon mux controller DT  bindings Pavel Machek <pavel@ucw.cz> - 2017-04-18 14:00 +0200
      Re: [RFC 1/2] dt-bindings: add mmio-based syscon mux controller DT  bindings Philipp Zabel <p.zabel@pengutronix.de> - 2017-04-18 13:00 +0200
  Re: [RFC 1/2] dt-bindings: add mmio-based syscon mux controller DT  bindings Rob Herring <robh@kernel.org> - 2017-04-20 00:10 +0200
    Re: [RFC 1/2] dt-bindings: add mmio-based syscon mux controller DT  bindings Philipp Zabel <p.zabel@pengutronix.de> - 2017-04-20 10:20 +0200
      Re: [RFC 1/2] dt-bindings: add mmio-based syscon mux controller DT  bindings Philipp Zabel <p.zabel@pengutronix.de> - 2017-04-20 15:10 +0200
      Re: [RFC 1/2] dt-bindings: add mmio-based syscon mux controller DT  bindings Rob Herring <robh@kernel.org> - 2017-04-20 15:50 +0200
    Re: [RFC 1/2] dt-bindings: add mmio-based syscon mux controller DT  bindings Philipp Zabel <p.zabel@pengutronix.de> - 2017-04-20 17:00 +0200

csiph-web